Skip to content

fix(inline-editable): add tooltips for controls #10538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

driskull
Copy link
Member

Related Issue: #10536

Summary

  • add title attribute for controls
  • change message text to remove "click to"
  • add test

@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Oct 14, 2024
@driskull driskull changed the title fix(inline-editable): use native tooltips for controls fix(inline-editable): add tooltips for controls Oct 14, 2024
@driskull driskull marked this pull request as ready for review October 14, 2024 22:30
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

benelan

This comment was marked as duplicate.

@driskull driskull added the skip visual snapshots Pull requests that do not need visual regression testing. label Oct 21, 2024
@driskull driskull merged commit 637ddfe into dev Oct 21, 2024
16 checks passed
@driskull driskull deleted the dris0000/inline-editable-native-tooltips branch October 21, 2024 19:07
@github-actions github-actions bot added this to the 2.13.2 patch milestone Oct 21, 2024
benelan pushed a commit that referenced this pull request Feb 8, 2025
**Related Issue:** #10536

## Summary

- add `title` attribute for controls
- change message text to remove "click to"
- add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants