Skip to content

feat(pagination): remove gap at start and end of component. #10523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat(pagination): remove gap at start and end of component. #10523

merged 1 commit into from
Oct 11, 2024

Conversation

aPreciado88
Copy link
Contributor

Related Issue: #10513

Summary

Remove the 2px gap at the start and end of component.

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Oct 11, 2024
@aPreciado88 aPreciado88 added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Oct 11, 2024
alisonailea
alisonailea approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I checked the Chromatic tests. I think the diff is correct based on the changes you made

@aPreciado88
Copy link
Contributor Author

@ashetland @SkyeSeitz Can you please take a look at the chromatic build?

@ashetland
Copy link
Contributor

Visuals lookin' good!

@aPreciado88 aPreciado88 merged commit 657f110 into dev Oct 11, 2024
16 checks passed
@aPreciado88 aPreciado88 deleted the aPreciado88/10513-remove-gap-at-start-and-end-of-component branch October 11, 2024 17:19
benelan pushed a commit that referenced this pull request Feb 8, 2025
@aPreciado88 @benelan
feat(pagination): remove gap at start and end of component. (#10523)
021a8f2 
**Related Issue:**
[#10513](#10513)

## Summary

Remove the 2px gap at the start and end of component.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonailea alisonailea alisonailea approved these changes

Assignees

@aPreciado88 aPreciado88

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-10-29 - Oct Milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aPreciado88 @ashetland @alisonailea