Skip to content

Commit b0cc797

Browse files
jcfrancobenelan
andcommitted
chore: drop unnecessary double build type workaround since components.d.ts is now tracked (#8199)
**Related Issue:** #8108 ## Summary Follow up from #8108 (review). Co-authored-by: Ben Elan <[email protected]>
1 parent 65a4f85 commit b0cc797

File tree

4 files changed

+3
-24
lines changed

4 files changed

+3
-24
lines changed

packages/calcite-components-angular/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
"private": true,
44
"scripts": {
55
"ng": "ng",
6-
"prebuild": "./support/stencilDoubleBuildTypesWorkaround.sh",
76
"prepublishOnly": "./support/prepublishBuildForCorrectVersion.sh",
87
"build": "ng build",
98
"clean": "rimraf dist node_modules .turbo .angular projects/component-library/dist"

packages/calcite-components-angular/support/stencilDoubleBuildTypesWorkaround.sh

Lines changed: 0 additions & 14 deletions
This file was deleted.

packages/calcite-components/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
"lint:scss": "stylelint --fix \"src/**/*.scss\" && prettier --write \"**/*.scss\" >/dev/null",
3535
"lint:ts": "eslint --ext .ts,.tsx --fix . && prettier --write \"**/*.ts?(x)\" >/dev/null",
3636
"posttest": "npm run test:prerender",
37-
"prepublishOnly": "./support/stencilDoubleBuildTypesWorkaround.sh",
37+
"prepublishOnly": "./support/buildForPreambleVersion.sh",
3838
"release:docs": "npm run docs && storybook-to-ghpages --existing-output-dir=docs",
3939
"start": "npm run util:clean-js-files && concurrently --kill-others --raw \"tsc --project ./tsconfig-demos.json --watch\" \"npm run build:watch-dev -- --serve\"",
4040
"test": "stencil test --no-docs --no-build --spec --e2e",

packages/calcite-components/support/stencilDoubleBuildTypesWorkaround.sh renamed to packages/calcite-components/support/buildForPreambleVersion.sh

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,7 @@
11
#!/usr/bin/env sh
22

3-
# This script builds the stencil components and ensures
4-
# the types are generated correctly as a workaround for
5-
# https://github.com/ionic-team/stencil/issues/3239
6-
#
7-
# It runs in the prepublishOnly NPM script hook
8-
# to prevent releasing with type bugs, and because
9-
# it needs to execute after versioning so that the
10-
# preamble in the dist source code is correct.
3+
# This runs in the prepublishOnly NPM script hook after versioning
4+
# so that the preamble in the dist source code is correct.
115
#
126
# Refs:
137
# https://github.com/lerna/lerna/blob/main/libs/commands/publish/README.md#lifecycle-scripts

0 commit comments

Comments
 (0)