moved common types to arcgis-rest-request package (#926)

* moved common types to arcgis-rest-request package

* export types

* Update README.md

Co-authored-by: Patrick Arlt <[email protected]>

* package-lock - remove types

* move item types to portal

* fix test

* fix test types

* fix tests

* removed IEnvelope

* moved ILayer type to arcgis-rest-service-admin package

and removed portions of the webmap types that are not used elsewhere

* remove unused types

* moved and removed types

- moved IPagingParams and IPagedResponse from to the `arcgis-rest-portal` package
- moved ITable and ILayerDefinition from webmap.ts (to service.ts)
- moved IField from webmap.ts (to feature.ts)
- removed other unused types in webmap.ts

* moved IServiceInfo

... into arcgis-rest-service-admin package

* moved IViewServiceSources

... into arcgis-rest-service-admin package

* Moved `IServiceNameAvailable` to `argis-rest-portal`

* cleanup types changes

* updated ts-node

to fix errors in node v16

Co-authored-by: Patrick Arlt <[email protected]>

Author: gavinr

README.md

@@ -75,13 +75,12 @@ For a specific package
 
 ### Packages
 
-- [`@esri/arcgis-rest-request`](./packages/arcgis-rest-request/) - Underpins other packages and supports making low-level requests.
+- [`@esri/arcgis-rest-request`](./packages/arcgis-rest-request/) - Core module implementing basic request code, shared TypeScript types and common utilities.
 - [`@esri/arcgis-rest-portal`](./packages/arcgis-rest-portal) - Methods for working with ArcGIS Online/Enterprise content and users.
 - [`@esri/arcgis-rest-feature-layer`](./packages/arcgis-rest-feature-layer) - Functions for querying and editing features inside of hosted feature layers.
 - [`@esri/arcgis-rest-service-admin`](./packages/arcgis-rest-service-admin) - Functions for administering hosted feature services.
 - [`@esri/arcgis-rest-geocoding`](./packages/arcgis-rest-geocoding) - Geocoding wrapper for `@esri/arcgis-rest-js`
 - [`@esri/arcgis-rest-routing`](./packages/arcgis-rest-routing) - Routing and directions wrapper for `@esri/arcgis-rest-js`.
-- [`@esri/arcgis-rest-types`](./packages/arcgis-rest-types/) - Common Typings for TypeScript developers.
 
 ### Frequently Asked Questions
 

package-lock.json

@@ -122,7 +122,7 @@
     "slug": "^0.9.1",
     "sri-toolbox": "0.2.0",
     "trash-cli": "^4.0.0",
-    "ts-node": "^10.2.1",
+    "ts-node": "^10.3.1",
     "typedoc": "^0.21.0",
     "typescript": "^4.0.0",
     "ultra-runner": "^3.10.5"
@@ -158,7 +158,6 @@
     "url": "https://github.com/Esri/arcgis-rest-js/issues"
   },
   "workspaces": [
-    "./packages/arcgis-rest-types",
     "./packages/arcgis-rest-request",
     "./packages/arcgis-rest-auth",
     "./packages/arcgis-rest-demographics",

package.json

@@ -40,7 +40,6 @@
   },
   "dependencies": {
     "@esri/arcgis-rest-request": "^3.3.0",
-    "@esri/arcgis-rest-types": "^3.3.0",
     "tslib": "^2.3.0"
   },
   "contributors": [

packages/arcgis-rest-auth/package.json

@@ -26,5 +26,6 @@ export {
   IUserRequestOptions,
   IFetchTokenResponse,
   IGenerateTokenResponse,
-  IAppAccess
+  IAppAccess,
+  IUser
 } from "@esri/arcgis-rest-request";

packages/arcgis-rest-auth/src/index.ts

@@ -42,7 +42,6 @@
     "node": ">=12.20.0"
   },
   "dependencies": {
-    "@esri/arcgis-rest-types": "^3.3.0",
     "tslib": "^2.3.0"
   },
   "peerDependencies": {

packages/arcgis-rest-demographics/package.json

@@ -4,9 +4,10 @@
 import {
   request,
   cleanUrl,
-  appendCustomParams
+  appendCustomParams,
+  IExtent
 } from "@esri/arcgis-rest-request";
-import { IEnvelope } from "@esri/arcgis-rest-types";
+
 
 import {
   ARCGIS_ONLINE_GEOENRICHMENT_URL,
@@ -33,7 +34,7 @@ export interface ICountry {
   continent: string;
   distanceUnits: string;
   esriUnits: string;
-  defaultExtent: IEnvelope;
+  defaultExtent: IExtent;
   defaultDatasetID: string;
   datasets?: string[];
   hierarchies?: IHierarchy[];

packages/arcgis-rest-demographics/src/getAvailableCountries.ts

@@ -2,11 +2,10 @@
  * Apache-2.0 */
 
 import {
-  IRequestOptions
+  IRequestOptions,
+  IFeatureSet
 } from "@esri/arcgis-rest-request";
 
-import { IFeatureSet } from "@esri/arcgis-rest-types";
-
 const ARCGIS_ONLINE_GEOENRICHMENTSERVER_URL = "https://geoenrich.arcgis.com/arcgis/rest/services/World/geoenrichmentserver"
 export const ARCGIS_ONLINE_GEOENRICHMENT_URL = `${ARCGIS_ONLINE_GEOENRICHMENTSERVER_URL}/Geoenrichment`;
 export const ARCGIS_ONLINE_STANDARD_GEOGRAPHY_QUERY_URL = `${ARCGIS_ONLINE_GEOENRICHMENTSERVER_URL}/StandardGeographyQuery`;

packages/arcgis-rest-demographics/src/helpers.ts

@@ -6,3 +6,11 @@ export * from "./getAvailableDataCollections.js";
 export * from "./getAvailableGeographyLevels.js";
 export * from "./getGeography.js";
 export * from "./queryDemographicData.js";
+
+// Types that are used in this package are re-exported for convenience and 
+// to make the links work correctly in the documentation pages.
+export type {
+  IRequestOptions,
+  IFeatureSet,
+  IExtent
+} from "@esri/arcgis-rest-request";

packages/arcgis-rest-demographics/src/index.ts

@@ -41,7 +41,6 @@
     "node": ">=12.20.0"
   },
   "dependencies": {
-    "@esri/arcgis-rest-types": "^3.3.0",
     "tslib": "^2.3.0"
   },
   "peerDependencies": {

packages/arcgis-rest-feature-layer/package.json

@@ -4,11 +4,10 @@
 import {
   request,
   cleanUrl,
-  appendCustomParams
+  appendCustomParams,
+  IFeature
 } from "@esri/arcgis-rest-request";
 
-import type { IFeature } from "@esri/arcgis-rest-types";
-
 import { ISharedEditOptions, IEditFeatureResult } from "./helpers.js";
 
 /**

packages/arcgis-rest-feature-layer/src/add.ts

@@ -4,11 +4,10 @@
 import {
   request,
   cleanUrl,
-  appendCustomParams
+  appendCustomParams,
+  IFeature
 } from "@esri/arcgis-rest-request";
 
-import type { IFeature } from "@esri/arcgis-rest-types";
-
 import { ISharedEditOptions, IApplyEditsResult } from "./helpers.js";
 
 /**