Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save semester evaluation form with a single click #699

Open
horcsinbalint opened this issue Feb 1, 2025 · 1 comment
Open

Save semester evaluation form with a single click #699

horcsinbalint opened this issue Feb 1, 2025 · 1 comment

Comments

@horcsinbalint
Copy link
Member

I received a request to send the whole evaluation form all at once with a single click and not require to send the components one-by-one. I'm a bit worried about how validation errors could be shown.

@kdmnk
Copy link
Contributor

kdmnk commented Feb 2, 2025

We reuse many components together with their endpoints there (eg. educational info update).
To avoid code duplication, I would first take a look at the form request objects, if these can be combined/grouped in any way ( https://laravel.com/docs/11.x/validation#creating-form-requests).
IMO this might complicate the code more than what the users gain from it in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants