Ensure that ballots with no votes don't contribute to quota

BertalanD · BertalanD · commit 7b8068fb4893 · 2025-02-12T16:59:18.000+01:00
diff --git a/app/Models/Question.php b/app/Models/Question.php
@@ -351,7 +351,12 @@ private function computeElectionResults(): Result
             $election->addCandidate($option->id);
         }
         foreach($this->longAnswers as $ballot){
-            $election->addVote(array_map('strval', json_decode($ballot->text)));
+            $preferences = json_decode($ballot->text);
+            if(count($preferences) == 0){
+                continue;
+            }
+
+            $election->addVote(array_map('strval', $preferences));
         }
 
         return $election->getResult('STV');

Original file line number	Diff line number	Diff line change
`@@ -351,7 +351,12 @@ private function computeElectionResults(): Result`
`351`	`351`	`$election->addCandidate($option->id);`
`352`	`352`	`}`
`353`	`353`	`foreach($this->longAnswers as $ballot){`
`354`		`- $election->addVote(array_map('strval', json_decode($ballot->text)));`
	`354`	`+ $preferences = json_decode($ballot->text);`
	`355`	`+ if(count($preferences) == 0){`
	`356`	`+ continue;`
	`357`	`+ }`
	`358`	`+`
	`359`	`+ $election->addVote(array_map('strval', $preferences));`
`355`	`360`	`}`
`356`	`361`
`357`	`362`	`return $election->getResult('STV');`