chore: Add more unit tests

Author: en-milie

src/main/java/com/endava/cats/fuzzer/contract/AbstractRequestBodyLinterFuzzer.java

@@ -6,7 +6,6 @@
 import io.github.ludovicianul.prettylogger.PrettyLogger;
 import io.github.ludovicianul.prettylogger.PrettyLoggerFactory;
 import io.swagger.v3.oas.models.Operation;
-import io.swagger.v3.oas.models.PathItem;
 import io.swagger.v3.oas.models.media.MediaType;
 import io.swagger.v3.oas.models.parameters.RequestBody;
 
@@ -26,7 +25,7 @@ public void process(FuzzingData data) {
         testCaseListener.addScenario(log, "Check if %s methods does not have a body".formatted(targetHttpMethod()));
         testCaseListener.addExpectedResult(log, "%s methods must define a requestBody with a valid schema".formatted(targetHttpMethod()));
 
-        Operation op = getOperation(data.getPathItem());
+        Operation op = HttpMethod.getOperation(targetHttpMethod(), data.getPathItem());
         if (op == null) {
             testCaseListener.skipTest(log, "%s method not present".formatted(targetHttpMethod()));
             return;
@@ -58,15 +57,6 @@ public void process(FuzzingData data) {
         }
     }
 
-    private Operation getOperation(PathItem item) {
-        return switch (targetHttpMethod()) {
-            case PUT -> item.getPut();
-            case POST -> item.getPost();
-            case PATCH -> item.getPatch();
-            default -> null;
-        };
-    }
-
     @Override
     protected String runKey(FuzzingData data) {
         return data.getPath();

src/main/java/com/endava/cats/fuzzer/contract/AbstractRequestWithoutBodyLinterFuzzer.java

@@ -6,7 +6,6 @@
 import io.github.ludovicianul.prettylogger.PrettyLogger;
 import io.github.ludovicianul.prettylogger.PrettyLoggerFactory;
 import io.swagger.v3.oas.models.Operation;
-import io.swagger.v3.oas.models.PathItem;
 
 import java.util.List;
 import java.util.Optional;
@@ -31,7 +30,7 @@ public void process(FuzzingData data) {
         testCaseListener.addScenario(log, "Check if %s methods have a body".formatted(targetHttpMethod()));
         testCaseListener.addExpectedResult(log, "%s methods must not have a body".formatted(targetHttpMethod()));
 
-        Operation operation = getOperation(data.getPathItem());
+        Operation operation = HttpMethod.getOperation(targetHttpMethod(), data.getPathItem());
         if (operation == null) {
             testCaseListener.skipTest(log, "%s method not present".formatted(targetHttpMethod()));
             return;
@@ -50,15 +49,6 @@ public void process(FuzzingData data) {
         }
     }
 
-    private Operation getOperation(PathItem item) {
-        return switch (targetHttpMethod()) {
-            case DELETE -> item.getDelete();
-            case GET -> item.getGet();
-            case HEAD -> item.getHead();
-            default -> null;
-        };
-    }
-
     @Override
     protected String runKey(FuzzingData data) {
         return data.getPath();

src/test/java/com/endava/cats/fuzzer/contract/OperationIdVerbPrefixLinterFuzzerTest.java

@@ -21,7 +21,10 @@
 import org.junit.jupiter.params.ParameterizedTest;
 import org.junit.jupiter.params.provider.CsvSource;
 import org.mockito.Mockito;
+import org.springframework.test.util.ReflectionTestUtils;
 
+import java.io.File;
+import java.util.List;
 import java.util.stream.Stream;
 
 @QuarkusTest
@@ -72,6 +75,22 @@ void shouldReportInfo() {
                 Mockito.eq("OperationId [{}] uses an allowed prefix"), Mockito.eq("getPeople"));
     }
 
+    @Test
+    void shouldReportErrorOnCustomVerbFile() {
+        ReflectionTestUtils.setField(namingArguments, "operationPrefixMapFile", new File("src/test/resources/verbs.properties"));
+        namingArguments.loadVerbMapFile();
+        PathItem pathItem = Mockito.mock(PathItem.class);
+        Operation operation = new Operation();
+        operation.setOperationId("getPeople");
+        Mockito.when(pathItem.getGet()).thenReturn(operation);
+
+        FuzzingData data = FuzzingData.builder().pathItem(pathItem).method(HttpMethod.GET).build();
+        operationIdVerbPrefixLinterFuzzer.fuzz(data);
+
+        Mockito.verify(testCaseListener, Mockito.times(1)).reportResultError(Mockito.any(), Mockito.any(), Mockito.eq("OperationId prefix mismatch"),
+                Mockito.eq("OperationId [{}] does not start with any allowed prefix {}"), Mockito.eq("getPeople"), Mockito.eq(List.of("fail")));
+    }
+
     @Test
     void shouldReturnSimpleClassNameForToString() {
         Assertions.assertThat(operationIdVerbPrefixLinterFuzzer).hasToString(operationIdVerbPrefixLinterFuzzer.getClass().getSimpleName());