Skip to content

initpegoutwallet only supports pkh descriptors on liquidv1 chain #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
philippem opened this issue Jan 14, 2022 · 1 comment
Closed

initpegoutwallet only supports pkh descriptors on liquidv1 chain #1087

philippem opened this issue Jan 14, 2022 · 1 comment

Comments

@philippem
Copy link
Contributor

philippem commented Jan 14, 2022

Is your feature request related to a problem? Please describe.

initpegoutwallet only supports pkh descriptors for production (liquidv1). wpkh and sh(wpkh) descriptors are only supported for non-liquidv1 chains. This is inconvenient for many PAK list users who wish to use segwit offline wallets. Segwit pegouts are supported by the watchman (see https://blockstream.info/liquid/tx/ca5bec433cd7c8838720fedec3e7a52deb5e73ee7a78b393b2bc55b3414c1303).

The code that restricts the form of descriptor for liquidv1 is at https://github.com/ElementsProject/elements/blob/elements-0.21/src/wallet/rpcwallet.cpp#L5420

Describe the solution you'd like

Support for all 3 forms of initpegoutwallet:

  1. initpegoutwallet "pkh(XPUB)"
  2. initpegoutwallet "wpkh(XPUB)"
  3. initpegoutwallet "sh(wpkh(XPUB))"

Describe alternatives you've considered

It is possible to construct peg-out transactions outside of an elementsd wallet and submit them (the above peg-out was performed that way).

Additional context

@psgreco
Copy link
Contributor

psgreco commented Apr 16, 2025

Fixed in #1294

@psgreco psgreco closed this as completed Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants