Skip to content

Commit ad1ed4e

Browse files
[generic_config_updater] Minor update - No logical code change (sonic-net#2028)
What I did Missed update from review comments in PR sonic-net#2020 s/os.system("sleep 10s")/time.sleep(10)/
1 parent 4f2773c commit ad1ed4e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

generic_config_updater/services_validator.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import os
2+
import time
23
from .gu_common import genericUpdaterLogging
34

45
logger = genericUpdaterLogging.get_logger(title="Service Validator")
@@ -33,7 +34,7 @@ def _service_restart(svc_name):
3334
logger.log(logger.LOG_PRIORITY_ERROR,
3435
f"Restart failed for {svc_name} rc={rc} after reset; Pause for 10s & retry",
3536
print_to_console)
36-
os.system("sleep 10s")
37+
time.sleep(10)
3738
rc = os.system(f"systemctl restart {svc_name}")
3839

3940
if rc == 0:

tests/generic_config_updater/service_validator_test.py

-1
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,6 @@ def mock_os_system_call(cmd):
6767
{ "cmd": "systemctl restart rsyslog", "rc": 1 }, # rsyslog restart; fails
6868
{ "cmd": "systemctl reset-failed rsyslog", "rc": 1 }, # reset; failure here just logs
6969
{ "cmd": "systemctl restart rsyslog", "rc": 1 }, # restart again; fails
70-
{ "cmd": "sleep 10s", "rc": 0 }, # sleep; rc ignored
7170
{ "cmd": "systemctl restart rsyslog", "rc": 1 }, # restart again; fails
7271
]
7372

0 commit comments

Comments
 (0)