Skip to content

Investigate and restart timed-out submissions #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eks-ebi opened this issue Apr 11, 2024 · 18 comments
Closed

Investigate and restart timed-out submissions #1285

eks-ebi opened this issue Apr 11, 2024 · 18 comments
Assignees

Comments

@eks-ebi
Copy link

eks-ebi commented Apr 11, 2024

Several submissions have been stuck validating and need to be restarted:

6608c665db8d9f000198b901

65f1f8330f82060001a1b6fd

🟡 65f9de3adb8d9f0001966a07
-- 🔴 Generate metadata for 65f9de3adb8d9f0001966a07 once the sync is complete.

66073fe60f82060001a48676

🟡 65d67ba1b73c7400016aa81a
-- 🔴 Generate metadata for 65d67ba1b73c7400016aa81a once the sync is complete.

This has been happening more often recently, so there may be an underlying issue that needs to be investigated.

@eks-ebi eks-ebi assigned eks-ebi and karatugo and unassigned eks-ebi Apr 11, 2024
@karatugo
Copy link
Member

karatugo commented Apr 12, 2024

6608c665db8d9f000198b901 - All files are valid, but the status update failed. I have force-pushed to bypass validation; they should be marked as valid shortly.

@karatugo
Copy link
Member

karatugo commented Apr 12, 2024

65f1f8330f82060001a1b6fd - The previous failure was due to a bug, now resolved (see EBISPOT/gwas-sumstats-service#308). I have restarted the validation, but encountered a new error: 'template invalid'.

@karatugo
Copy link
Member

karatugo commented Apr 12, 2024

65f9de3adb8d9f0001966a07 - It appears to be a network error. I restarted the validation, will follow up on that.

@karatugo
Copy link
Member

karatugo commented Apr 12, 2024

66073fe60f82060001a48676 - The studies are across two different folders, causing the validation pipeline to fail in locating them. Is there a policy requiring files to be stored in a single, flat folder? Here are the contents of the specified directory for reference:

ls -ltr <private ftp folder name>
total 64
drwxrws--- 2 gwas_cat spot 1940 Apr 2 23:34 EBIsumstats
drwxrws--- 2 gwas_cat spot 1940 Apr 11 14:38 finalv

Update: ✅ The user fixed the file upload and validation is successful now.

@karatugo
Copy link
Member

🟡 65f9de3adb8d9f0001966a07 - Increased mem and time constraints and submitted again for validation.

@karatugo
Copy link
Member

🟡 65f9de3adb8d9f0001966a07 - validation passed, waiting for db status update.

For future reference, I unzipped and zipped back the file X10647.18.tsv.gz in the private ftp. The reason was that file description was missing the word 'gzip' as our file extension finder logic depends on that keyword. Details and the ticket for further investigation: EBISPOT/gwas-sumstats-service#317

@Santhi1901
Copy link

Santhi1901 commented Apr 22, 2024

there is another submission showing VALIDATING: 65d67ba1b73c7400016aa81a. @karatugo, can you please look into this?

@karatugo
Copy link
Member

karatugo commented Apr 22, 2024

🟡 65f9de3adb8d9f0001966a07 - ran with skipValidation again, hopefully db update won't break this time

Update. DB update worked but the files are not moved to the public ftp.

@sprintell
Copy link
Member

@karatugo
Copy link
Member

karatugo commented Apr 24, 2024

🟡 65f9de3adb8d9f0001966a07 - expect the study files in the public ftp tomorrow in a few days. I'll regenerate the metadata files later.

@Santhi1901
Copy link

@karatugo

The submission (65f9de3adb8d9f0001966a07) is under embargo, so the sumstats files are not in public FTP.

In production, only some GCSTs have files in the folder.

When I checked, the files were there for GCST90421033-GCST90421797 (I did not check all GCSTs between these, but most of them have sumstats files). GCST90421798-GCST90428040 has empty folders.

@karatugo
Copy link
Member

@Santhi1901 I thought we could process all 7,008 files in one sync, but it turns out our system can only process about 700 files each night. It will take several more days to fully sync. If this is too slow, I can explore other solutions, such as initiating a manual sync.

@karatugo
Copy link
Member

🟡 65d67ba1b73c7400016aa81a - expect the study files in the public ftp in a few days. I'll regenerate the metadata files later.

@karatugo
Copy link
Member

karatugo commented May 3, 2024

65d67ba1b73c7400016aa81a and 65f9de3adb8d9f0001966a07 are not in the public ftp yet.

@karatugo
Copy link
Member

karatugo commented May 7, 2024

65f9de3adb8d9f0001966a07 is now in the public ftp. Their yamls should be in the public ftp tomorrow (from GCST90421033 to GCST90428040).

@karatugo
Copy link
Member

karatugo commented May 9, 2024

Santhi reported that 65d67ba1b73c7400016aa81a is showing validating again.

@karatugo
Copy link
Member

karatugo commented May 9, 2024

65d67ba1b73c7400016aa81a is showing submission complete now.

I updated the sumstats meta table as studies were not existing for this submission. Updated the table by a script using PyMongo. For details: see /hps/nobackup/parkinso/spot/gwas/scratch/goci1285

@sprintell
Copy link
Member

All the submission has restarted and validated, but some of them are not in the public ftp , ... cannot generate the mssing yaml files, we either wait for them to get to the public ftp, or close them and handle them case by case.

We leave it as it is, new yaml will be generated when curator edits the template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants