-
Notifications
You must be signed in to change notification settings - Fork 720
End less loop on InteractionService.GetAuthorizationContextAsync call #4386
Comments
Can you reproduce this using one of our samples? |
Let me give that a try today and get back here with an update. |
@brockallen Apologies for the delay in getting back. Unfortunately I am unable to re-produce the issue with the quick start. But I know the usecase that caused this loop.
Tried the below steps to reproduce the issue
Notice the user presented with a login screen,as per the profile Service Is Active context (but the user is already logged in - from the auth cookie in the request). in our case, when we tried to login on the After we replaced the LabelService constructor code |
Perhaps related? #4644 If it's the same, then we can close this issue as a PR has been submitted. |
I am not sure, this issue is not involving the external authentication provider. But we have the following in the GET Login action method Since the ProfileService - IsActiveAsync is setting the IsActiveContext to false, so the identityservices are challenge the authentication as a result the Login must have initiated, which case the above code will be executing. So, if the issue is in the HttpContext.SignOutAsync(IdentityConstants.ExternalScheme) method with a valid cookie in the request, then yes, it is related. |
Closing. If you still have issues, feel free to reopen. |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
The issue exists with Identity Server 3.1.1 - .Net core 3.1
but not with the Identity server 2.3.4 - .Net core 2.1.
The issue causing the stack overflow exception and causing the w3wp.exe crash eventually application going down.
The issue has been reported in the aspnetcore repo first and identified the call stack, after the modifications by removing the call to
interactionService.GetAuthorizationContextAsync
the new build is not producing the issue, hence its here.the issue can not produced consistently in all environments, some of our environments such as development are working without any issues but the same is failing in our other all environments. Some environments the issue can be produces with a simple multiple logins using a multiple clients but in other environments ZAP scan is reproducing.
Design/ implementation
AccountsViewModel fluent validation
constructor calling theinteractionService.GetAuthorizationContextAsync
passing thereturnUrl
to find out theClientId
to apply the relevant customization to the login page GETIssue / Steps to reproduce the problem
Using the OWASP ZAP scan - attack mode insane strength.
some of our environments -
Identity server with an angular client and MVC client can also be produced with a simple browsing of the sites.
Login using the angular app.
Initialize the login to MVC application, which SSO will kicks in and then the application is crashing.
Relevant parts of the log file
See the dump call stack in here
The text was updated successfully, but these errors were encountered: