remove redundant check for isset() which is unnecessary in case of unset() (#21)

* remove redundant isset check

* fix typos

* deconstruct array using shorthand syntax

* fix typo changes

* revert change for list syntax

Author: samundra

README.MD

@@ -1,18 +1,20 @@
 [![StyleCI](https://github.styleci.io/repos/159037396/shield?branch=master)](https://github.styleci.io/repos/159037396)
+
 ### Introduction
+
 <a href = "https://github.com/the-control-group/voyager">Voyager </a> is an awesome admin tool for laravel.
-It's easy to create admin tool for CMS using it awesome features ```BREAD```.
+It is very easy to create admin tool for CMS using Voyager's awesome feature [BREAD](https://voyager.readme.io/docs/bread).
 
 Voyager has limitation for the deployment (after you finish the work, create bread and need to publish in production. :) )
 
-Voyager Deployment Orchestrator is the package which will listen ```BREAD  Events``` (Add, Update Delete) and will generate
+Voyager Deployment Orchestrator is the package which will listen `BREAD  Events` (Add, Update Delete) and will generate
 files, so that BREAD data can be easily seeded.
 
 ### Installation
 
 ```composer require drudge-rajen/voyager-deployment-orchestrator```
 
-Publish the default config and seeder file.
+Then publish the default config and seeder file.
 
 ```
 php artisan vendor:publish --provider="DrudgeRajen\VoyagerDeploymentOrchestrator\VoyagerDeploymentOrchestratorServiceProvider"
@@ -28,21 +30,20 @@ return [
 ];
 ```
 
-
-After Publishing the ``VoyagerDeploymentOrchestratorSeeder`` class file
-autoload the composer so that laravel knows about the seeder.
+After Publishing the `VoyagerDeploymentOrchestratorSeeder` class file,
+autoload composer so that laravel knows about new seeders.
 
 ``composer dump-autoload``
 
 ### Usage
 Voyager Fires Events on Insert, Update, and Delete of BREAD.
-This package listens to those events and creates the respective seeder files.
+This package listens for those events and creates respective seeder files.
 
-To run the seeder file :
+#### To run the seeder file:
 
-``php artisan db:seed --class=VoyagerDeploymentOrchestratorSeeder``
+```php artisan db:seed --class=VoyagerDeploymentOrchestratorSeeder```
 
-### Contribuing
+### Contributing
 
 Run phpcs linter to check for any error that may happen during PR.
 

composer.json

@@ -1,7 +1,13 @@
 {
   "name": "drudge-rajen/voyager-deployment-orchestrator",
   "description": "Package for Voyager BREAD Deployment.",
-  "keywords": ["laravel", "voyager", "voyager-deployment", "voyager-seeder", "bread-seeder"],
+  "keywords": [
+    "laravel",
+    "voyager",
+    "voyager-deployment",
+    "voyager-seeder",
+    "bread-seeder"
+  ],
   "type": "library",
   "license": "MIT",
   "require": {

src/ContentManager/ContentManager.php

@@ -121,11 +121,9 @@ private function populateDataTypeSeederContent(string $stub, DataType $dataType)
 
         $dataTypeArray = $dataType->toArray();
 
-        //Here, we cannot do $dataType->unsetRelations('translations)
-        // because voyager first fire events and then save the translations.
-        if (isset($dataTypeArray['translations'])) {
-            unset($dataTypeArray['translations']);
-        }
+        // Here, we cannot do $dataType->unsetRelations('translations')
+        // because voyager first fires events and then saves translations.
+        unset($dataTypeArray['translations']);
 
         return $this->populateInsertStatements(
             $stub,
@@ -307,7 +305,7 @@ private function populateTranslationStatements(string $stub, DataType $dataType)
      *
      * @param string $stub
      * @param string $tableName
-     * @param $dataTypeArray
+     * @param array $dataTypeArray
      *
      * @return mixed|string
      */
@@ -330,8 +328,8 @@ private function populateInsertStatements(
     /**
      * Replace String.
      *
-     * @param $search
-     * @param $replace
+     * @param string $search
+     * @param string $replace
      * @param $stub
      *
      * @return mixed

src/OrchestratorHandlers/BreadAddedHandler.php

@@ -31,10 +31,10 @@ public function handle(BreadChanged $breadAdded)
     {
         $dataType = $breadAdded->dataType;
 
-        //Generate Data Type Seeder File.
+        // Generate Data Type Seeder File.
         $this->filesGenerator->generateDataTypeSeedFile($dataType);
 
-        //Generate Data Row Seeder File.
+        // Generate Data Row Seeder File.
         return $this->filesGenerator->generateDataRowSeedFile($dataType);
     }
 }

src/OrchestratorHandlers/BreadDeletedHandler.php

@@ -45,7 +45,7 @@ public function handle(BreadChanged $breadDataDeleted) : bool
             Voyager::model('Permission')->removeFrom($dataType->name);
         }
 
-        //Finally, We can delete seed files.
+        // Finally, We can delete seed files.
         $this->fileGenerator->deleteSeedFiles($dataType);
 
         // After deleting seeds file, we create new seed file in order to rollback