Skip to content

Convert Project ownership SendGrid templates to the new Mail template styling #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MeesvanStraten opened this issue Oct 12, 2021 · 4 comments
Assignees
Labels
Hacktoberfest hacktoberfest-accepted priority Only assign this label if it's asked to assign this label

Comments

@MeesvanStraten
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Neal create nice DeX sendgrid templates. The current templates for transfering a project to new owner needs to be styled with attributes from this new template. You do not need to create new templates but only update the components like buttons etc with the new styles.

Make sure to include the paramaters like {{Name}}.

@MeesvanStraten MeesvanStraten added the priority Only assign this label if it's asked to assign this label label Oct 12, 2021
@elislaats elislaats self-assigned this Oct 14, 2021
@elislaats
Copy link
Contributor

Hi, @MeesvanStraten I updated the templates as requested!

I also changed the way @NealGeilen set up the template. He put the design as one of the templates to be copied and reused, but there's a neater way to do it through adding a design to the built in 'design library' now when you start creating a template, you'll be able to choose the default design and it'll be automatically applied.

I'll be adding a page to the wiki about how access and use SendGrid, just to make it clear for anyone else who'll be working on it.

I would like to know what you think of the way I applied the designs. And if I'm correct the [MAIN TEMPLATE] can be removed because it became redundant when I added the Design to the Design Library but please let me know if you agree with that 😄

@MeesvanStraten
Copy link
Contributor Author

Hey, Templates look great 👍 . And the use of the design library is really neat. Creating a new template now gives the option of using the design which is great. Thanks!

And the main template now can indeed be removed. Great work 🥇 .

@elislaats
Copy link
Contributor

Thanks for the feedback @MeesvanStraten! I removed the old template. 👍

This is the wiki article I wrote: https://github.com/DigitalExcellence/dex-frontend/wiki/How-to-use:-SendGrid I hope it's not to elaborate, but I think it would be also valuable to also add a part about how it's used in the back-end.

I'm not really sure how to do that myself, maybe you can write it or maybe you know who worked on that and would be able to quickly type something up about it 😄

@MeesvanStraten
Copy link
Contributor Author

Sure I will update the part of sendgrid backend integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest hacktoberfest-accepted priority Only assign this label if it's asked to assign this label
Projects
None yet
Development

No branches or pull requests

2 participants