Skip to content

Pagination query parameters are not cleared on new search #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matir8 opened this issue Sep 23, 2020 · 1 comment · Fixed by #360
Closed

Pagination query parameters are not cleared on new search #302

matir8 opened this issue Sep 23, 2020 · 1 comment · Fixed by #360
Assignees
Labels
bug Something isn't working

Comments

@matir8
Copy link
Contributor

matir8 commented Sep 23, 2020

Describe the bug
Currently, we can only search for projects only on the selected page. For example, when you go to the second page of the projects list and you enter a search the results will be shown only for projects on the second page. We want to search through all the projects. So we should clear the pagination query parameters when making a new search.

To Reproduce

  1. Search for a project on the first page
  2. Make sure that it appears in the results
  3. Clear the search query
  4. Go to the second page
  5. Execute the same search
  6. Now the project that was found on the first page is missing

Expected behavior
When searching for a project the results should not be limited only to the current page. Pagination query parameters should be cleared on every new search.

@matir8 matir8 added the bug Something isn't working label Sep 23, 2020
@Brend-Smits
Copy link
Member

Nice find :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants