Skip to content

Commit 511ca4f

Browse files
authored
Merge pull request #483 from DigitalExcellence/master
Merge master to develop after release
2 parents b735a54 + 6f9e8cf commit 511ca4f

File tree

7 files changed

+27
-30
lines changed

7 files changed

+27
-30
lines changed

CHANGELOG.md

+19-5
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,36 @@ to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
99

1010
### Added
1111

12-
- Added icons to the call-to-action buttons - [#451](https://github.com/DigitalExcellence/dex-frontend/issues/451)
13-
1412
### Changed
1513

16-
- Hide data sources that have the IsVisible property set to false - [#474](https://github.com/DigitalExcellence/dex-frontend/issues/474)
17-
1814
### Deprecated
1915

2016
### Removed
2117

2218
### Fixed
19+
20+
### Security
21+
22+
## Release v.1.3.0-beta - 05-05-2021
23+
24+
### Added
25+
26+
- Added icons to the call-to-action buttons - [#451](https://github.com/DigitalExcellence/dex-frontend/issues/451)
27+
28+
### Changed
29+
30+
- Hide data sources that have the IsVisible property set to false - [#474](https://github.com/DigitalExcellence/dex-frontend/issues/474)
31+
32+
### Fixed
33+
2334
- Fixed issue where the edit- & delete project would always be shown - [#458](https://github.com/DigitalExcellence/dex-frontend/issues/458)
2435
- Fixed issue where the privacy modal and alerts were not responsive - [#426](https://github.com/DigitalExcellence/dex-frontend/issues/426)
2536
- Fixed issue where the wizard would not import projects that missed a required property. [#471](https://github.com/DigitalExcellence/dex-frontend/issues/471)
2637

27-
### Security
38+
### Hotfix
39+
40+
- Fixed issue where icon were not being previewed in edit project overview. [Hotfix](https://github.com/DigitalExcellence/dex-frontend/pull/480)
41+
- Fixed issue where project was still being showed after deletion until refresh . [Hotfix](https://github.com/DigitalExcellence/dex-frontend/pull/481)
2842

2943
## Release v.1.2.0-beta - 15-04-2021
3044

src/app/components/file-uploader/file-uploader.component.html

-11
Original file line numberDiff line numberDiff line change
@@ -30,17 +30,6 @@
3030
</div>
3131
<p class="form-footnote">The recommended dimensions for an icon are atleast 512x512</p>
3232
<div *ngIf="showPreview" class="files-list">
33-
<div class="single-file" *ngFor="let file of files; let i = index">
34-
<div class="file-info">
35-
<button type="button" class="btn btn-icon btn-danger" aria-label="error"
36-
(click)="deleteFile(i)"><span aria-hidden="true">&times;</span>
37-
</button>
38-
<img alt="image-preview" class="file-icon" [src]=file?.preview>
39-
<h4 class="file-name">
40-
{{ file?.name }}
41-
</h4>
42-
<h4 class="file-size">
43-
<div class="files-list">
4433
<div class="single-file" *ngFor="let file of files; let i = index">
4534
<div class="file-info">
4635
<button type="button" class="btn btn-icon btn-danger" aria-label="error" (click)="deleteFile(i)"><span

src/app/components/file-uploader/file-uploader.component.ts

-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ export class FileUploaderComponent {
123123
this.alertService.pushAlert(alertConfig);
124124
this.deleteFile(this.files.indexOf(file));
125125
}
126-
127126
}
128127
}
129128

src/app/error-handler/sentry.error-handler.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {environment} from 'src/environments/environment';
2020

2121
Sentry.init({
2222
dsn: environment.sentryDsnUrl,
23-
release: 'dex-frontend@1.2.0-beta'
23+
release: 'dex-frontend@1.3.0-beta'
2424
});
2525

2626
/**

src/app/modules/project/edit/edit.component.html

+5-12
Original file line numberDiff line numberDiff line change
@@ -76,18 +76,11 @@ <h3>Description*</h3>
7676
<div class="col-12">
7777
<div class="project-icon-picker">
7878
<h3>Project icon</h3>
79-
<app-file-uploader [acceptMultiple]="acceptMultiple" [acceptedTypes]="acceptedTypes">
79+
<app-file-uploader [acceptMultiple]="acceptMultiple" [acceptedTypes]="acceptedTypes" [showPreview]="showPreview">
8080
</app-file-uploader>
8181
</div>
8282
</div>
8383
</div>
84-
<div class="row">
85-
<div class="col-12">
86-
<div>
87-
<p class="form-footnote">The recommended dimensions for an icon are atleast 512x512</p>
88-
</div>
89-
</div>
90-
</div>
9184
</form>
9285

9386
<ng-container *ngIf="callToActionOptions.length > 1">
@@ -105,7 +98,7 @@ <h3>Text</h3>
10598
</select>
10699
</div>
107100
</div>
108-
101+
109102
<div class="col-6">
110103
<div>
111104
<h3>Link</h3>
@@ -167,7 +160,7 @@ <h3>Collaborators</h3>
167160
<button type="button" class="btn btn-icon btn-danger" aria-label="error"
168161
(click)="onClickDeleteCollaborator(collaborator)"> <span aria-hidden="true"> &times; </span>
169162
</button>
170-
163+
171164
<div class="collaborator-text-container w-100">
172165

173166
<div>
@@ -176,10 +169,10 @@ <h3>Collaborators</h3>
176169
<p class="collaborator-text large dash">-</p>
177170
<div>
178171
<p class="collaborator-text large" [tooltip]="collaborator?.role" delay="300">{{collaborator?.role}}</p>
179-
</div>
172+
</div>
180173

181174
</div>
182-
175+
183176
<hr class="dashed">
184177
</div>
185178
</div>

src/app/modules/project/edit/edit.component.ts

+1
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ export class EditComponent implements OnInit {
4747
@ViewChild(FileUploaderComponent) fileUploader: FileUploaderComponent;
4848
public acceptedTypes = ['image/png', 'image/jpg', 'image/jpeg'];
4949
public acceptMultiple = false;
50+
public showPreview = true;
5051

5152
/**
5253
* Formgroup for entering project details.

src/app/modules/project/overview/overview.component.ts

+1
Original file line numberDiff line numberDiff line change
@@ -374,6 +374,7 @@ export class OverviewComponent implements OnInit, AfterContentInit {
374374
if (this.location.path().startsWith('/project/details')) {
375375
this.location.replaceState('/project/overview');
376376
this.updateSEOTags();
377+
this.onInternalQueryChange();
377378
}
378379
}
379380
));

0 commit comments

Comments
 (0)