Skip to content

Unclear Resource / ResourceResults #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
niraymak opened this issue Mar 31, 2021 · 2 comments · Fixed by #500
Closed

Unclear Resource / ResourceResults #413

niraymak opened this issue Mar 31, 2021 · 2 comments · Fixed by #500
Assignees
Labels
Good first issue Good first issue to get to know the project internally. priority Only assign this label if it's asked to assign this label

Comments

@niraymak
Copy link
Member

Is your feature request related to a problem? Please describe.
During our retrospective one of the points of attention was that we have many resources and resource results classes.

Describe the solution you'd like
Research how we can improve this. Maybe we can change naming conventions for resources and resource results to make it more clear. It also might be a good idea to investigate how this is handled in other projects.

Production URL
https://github.com/DigitalExcellence/dex-backend/tree/develop/API/Resources

Additional context

@RubenFricke
Copy link
Member

In my opinion, I don't think the resources/resource results are really a problem, I think the problem is more with the fact that there are just too many in that one folder. Maybe adding subfolders would help and I think that the existing idea to migrate to microservice architecture would also help because it would split the resource results into different projects (contact @Maxvanhattum for information about the microservice ideas/plans).

@niraymak niraymak added the priority Only assign this label if it's asked to assign this label label Apr 1, 2021
@MeesvanStraten
Copy link
Contributor

(For whoever that will work on this) For now I think it would be nice to atleast create a structured folder system. It's a quick fix and does not cost to much time.

@MeesvanStraten MeesvanStraten added the Good first issue Good first issue to get to know the project internally. label Sep 1, 2021
@MeesvanStraten MeesvanStraten self-assigned this Sep 6, 2021
@MeesvanStraten MeesvanStraten linked a pull request Sep 7, 2021 that will close this issue
13 tasks
@MeesvanStraten MeesvanStraten mentioned this issue Sep 7, 2021
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good first issue to get to know the project internally. priority Only assign this label if it's asked to assign this label
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants