Skip to content

Refactor controllers #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
niraymak opened this issue Mar 31, 2021 · 4 comments
Closed

Refactor controllers #411

niraymak opened this issue Mar 31, 2021 · 4 comments
Labels
priority Only assign this label if it's asked to assign this label

Comments

@niraymak
Copy link
Member

Is your feature request related to a problem? Please describe.
In the retrospective one of the points of attention was that there is too much logic / code in the endpoints in the API.
An example is in the link below.

Describe the solution you'd like
Research and refactor a way to make endpoints shorter.

Production URL
https://github.com/DigitalExcellence/dex-backend/blob/develop/API/Controllers/ProjectController.cs#L384

@niraymak niraymak added the priority Only assign this label if it's asked to assign this label label Apr 1, 2021
@Arilith Arilith self-assigned this May 23, 2021
@Arilith
Copy link
Contributor

Arilith commented May 23, 2021

I spoke about this with Niray last Friday and will research a solution in the coming time. One thing that already definitely could help is a central exception/error class, which would move all the exceptions to their own respective place instead of in the controllers.

@Arilith
Copy link
Contributor

Arilith commented Jun 8, 2021

@MeesvanStraten
Copy link
Contributor

@Arilith Hey, Are you still working on DeX this semester? and maybe even on this issue? Thanks!

@Arilith
Copy link
Contributor

Arilith commented Sep 2, 2021

@Arilith Hey, Are you still working on DeX this semester? and maybe even on this issue? Thanks!

Hi Mees,

No, sadly I won't be joining Dex this semester as I've moved to the TU/e and probably won't have time to work on this. I wish you all the best of luck this semester!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority Only assign this label if it's asked to assign this label
Projects
None yet
Development

No branches or pull requests

4 participants