Skip to content

Class library MessageBrokerPublisher retrieves connection parameters itself #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Maxvanhattum opened this issue Jan 15, 2021 · 0 comments · Fixed by #357
Closed

Class library MessageBrokerPublisher retrieves connection parameters itself #356

Maxvanhattum opened this issue Jan 15, 2021 · 0 comments · Fixed by #357
Assignees
Labels
bug Something isn't working

Comments

@Maxvanhattum
Copy link
Contributor

Describe the bug
Class library MessageBrokerPublisher retrieves connection parameters itself, while it should be passed in by the services that imports this library.

To Reproduce
Steps to reproduce the behavior:

  1. Go to MessageBrokerPublisher project
  2. Open folder Services
  3. Open RabbitMQConnectionFactory.cs
  4. Look at lines 27/28/29 and lines 38/39/40

Expected behavior
The RabbitMQConnectionFactory should accepts these values in the constructor, instead of trying to retrieve them from the environment. And it should not check if these values are set in the environment, delegating this to the service utilizing this library (preferably the service uses an appsettings.json file, overriding the values if environment variables are set.

@Maxvanhattum Maxvanhattum added the bug Something isn't working label Jan 15, 2021
@Maxvanhattum Maxvanhattum self-assigned this Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant