validity as timestamps

polymorf · polymorf · commit 338a94fe67b0 · 2013-06-09T21:52:11.000+02:00
diff --git a/lib/pem.js b/lib/pem.js
@@ -360,10 +360,10 @@ function fetchCertificateData(certData, callback){
     }
 
     certValues.validity = {};
-    tmp = certData.match(/Not Before\s?:\s?([^\n]*)\n/)
-    certValues.validity.start = tmp && tmp[1] || "";
-    tmp = certData.match(/Not After\s?:\s?([^\n]*)\n/)
-    certValues.validity.end = tmp && tmp[1] || "";
+    if ((tmp = certData.match(/Not Before\s?:\s?([^\n]*)\n/)) && tmp.length>1)
+       certValues.validity.start = Date.parse(tmp[1]);
+    if ((tmp = certData.match(/Not After\s?:\s?([^\n]*)\n/)) && tmp.length>1)
+       certValues.validity.end = Date.parse(tmp[1]);
 
     callback(null, certValues);
 }

Original file line number	Diff line number	Diff line change
`@@ -360,10 +360,10 @@ function fetchCertificateData(certData, callback){`
`360`	`360`	`}`
`361`	`361`
`362`	`362`	`certValues.validity = {};`
`363`		`- tmp = certData.match(/Not Before\s?:\s?([^\n]*)\n/)`
`364`		`- certValues.validity.start = tmp && tmp[1] \|\| "";`
`365`		`- tmp = certData.match(/Not After\s?:\s?([^\n]*)\n/)`
`366`		`- certValues.validity.end = tmp && tmp[1] \|\| "";`
	`363`	`+ if ((tmp = certData.match(/Not Before\s?:\s?([^\n]*)\n/)) && tmp.length>1)`
	`364`	`+ certValues.validity.start = Date.parse(tmp[1]);`
	`365`	`+ if ((tmp = certData.match(/Not After\s?:\s?([^\n]*)\n/)) && tmp.length>1)`
	`366`	`+ certValues.validity.end = Date.parse(tmp[1]);`
`367`	`367`
`368`	`368`	`callback(null, certValues);`
`369`	`369`	`}`