managed only services will only tail logs on deploy. Update info/warning text (#635)

* managed only services will only tail logs. Update info/warning text

* code review updates

* update code review: text will should managed resources without explicity depends from other services.

* update code review: tell uses to put any dangling managed service as dependencies in depends_on section.

* update to not use depends_on (not currently supported). use serviceinfo rather than project

* update exit text

Author: nullfunc

src/cmd/cli/command/compose.go

@@ -18,6 +18,25 @@ import (
 	"github.com/spf13/cobra"
 )
 
+func isManagedService(service *defangv1.Service) bool {
+	if service == nil {
+		return false
+	}
+
+	return service.StaticFiles != nil || service.Redis != nil || service.Postgres != nil
+}
+
+func GetUnreferencedManagedResources(serviceInfos []*defangv1.ServiceInfo) []string {
+	managedResources := make([]string, 0)
+	for _, service := range serviceInfos {
+		if isManagedService(service.Service) {
+			managedResources = append(managedResources, service.Service.Name)
+		}
+	}
+
+	return managedResources
+}
+
 func makeComposeUpCmd() *cobra.Command {
 	behavior := Behavior(defangv1.Behavior_DEVELOPMENT)
 	composeUpCmd := &cobra.Command{
@@ -45,6 +64,11 @@ func makeComposeUpCmd() *cobra.Command {
 
 			printPlaygroundPortalServiceURLs(deploy.Services)
 
+			var managedResources = GetUnreferencedManagedResources(deploy.Services)
+			if len(managedResources) > 0 {
+				term.Warnf("Defang cannot monitor status of the following managed service(s): %v.\n   To check if the managed service is up, check the status of the service which depends on it.", managedResources)
+			}
+
 			if detach {
 				term.Info("Detached.")
 				return nil
@@ -107,6 +131,8 @@ func makeComposeUpCmd() *cobra.Command {
 					if errors.As(context.Cause(tailCtx), &errDeploymentFailed) {
 						term.Warn(errDeploymentFailed)
 						failedServices = []string{errDeploymentFailed.Service}
+					} else if len(managedResources) > 0 {
+						term.Warn("Managed services have been deployed but not all services may be available yet.")
 					} else {
 						term.Warn("Deployment is not finished. Service(s) might not be running.")
 						// TODO: some services might be OK and we should only debug the ones that are not

src/cmd/cli/command/compose_test.go

@@ -0,0 +1,77 @@
+package command
+
+import (
+	"testing"
+
+	defangv1 "github.com/DefangLabs/defang/src/protos/io/defang/v1"
+)
+
+func TestGetUnreferencedManagedResources(t *testing.T) {
+
+	t.Run("no services", func(t *testing.T) {
+		project := []*defangv1.ServiceInfo{}
+		managed := GetUnreferencedManagedResources(project)
+		if len(managed) != 0 {
+			t.Errorf("Expected 0 managed resources, got %d (%v)", len(managed), managed)
+		}
+	})
+
+	t.Run("one service all managed", func(t *testing.T) {
+		project := []*defangv1.ServiceInfo{}
+		project = append(project, &defangv1.ServiceInfo{
+			Service: &defangv1.Service{Name: "service1", Postgres: &defangv1.Postgres{}}})
+
+		managed := GetUnreferencedManagedResources(project)
+		if len(managed) != 1 {
+			t.Errorf("Expected 1 managed resource, got %d (%v)", len(managed), managed)
+		}
+	})
+
+	t.Run("one service unmanaged", func(t *testing.T) {
+		project := []*defangv1.ServiceInfo{}
+		project = append(project, &defangv1.ServiceInfo{
+			Service: &defangv1.Service{Name: "service1"}})
+
+		managed := GetUnreferencedManagedResources(project)
+		if len(managed) != 0 {
+			t.Errorf("Expected 0 managed resource, got %d (%v)", len(managed), managed)
+		}
+	})
+
+	t.Run("one service unmanaged, one service managed", func(t *testing.T) {
+		project := []*defangv1.ServiceInfo{}
+		project = append(project, &defangv1.ServiceInfo{
+			Service: &defangv1.Service{Name: "service1"}})
+		project = append(project, &defangv1.ServiceInfo{
+			Service: &defangv1.Service{Name: "service2", Postgres: &defangv1.Postgres{}}})
+
+		managed := GetUnreferencedManagedResources(project)
+		if len(managed) != 1 {
+			t.Errorf("Expected 1 managed resource, got %d (%v)", len(managed), managed)
+		}
+	})
+
+	t.Run("two service two unmanaged", func(t *testing.T) {
+		project := []*defangv1.ServiceInfo{}
+		project = append(project, &defangv1.ServiceInfo{
+			Service: &defangv1.Service{Name: "service1"}})
+		project = append(project, &defangv1.ServiceInfo{
+			Service: &defangv1.Service{Name: "service2"}})
+
+		managed := GetUnreferencedManagedResources(project)
+		if len(managed) != 0 {
+			t.Errorf("Expected 0 managed resource, got %d (%v)", len(managed), managed)
+		}
+	})
+
+	t.Run("one service two managed", func(t *testing.T) {
+		project := []*defangv1.ServiceInfo{}
+		project = append(project, &defangv1.ServiceInfo{
+			Service: &defangv1.Service{Name: "service1", Postgres: &defangv1.Postgres{}, Redis: &defangv1.Redis{}}})
+
+		managed := GetUnreferencedManagedResources(project)
+		if len(managed) != 1 {
+			t.Errorf("Expected 1 managed resource, got %d (%s)", len(managed), managed)
+		}
+	})
+}