Skip to content

Commit df708c6

Browse files
lionellolionello
committed
chore: preceed TODOs with semicolon [no ci]
1 parent 26b4255 commit df708c6

File tree

10 files changed

+21
-21
lines changed

10 files changed

+21
-21
lines changed

‎src/cmd/cli/main.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -590,7 +590,7 @@ func main() {
590590
rootCmd.AddCommand(tokenCmd)
591591

592592
// Login Command
593-
// loginCmd.Flags().Bool("skip-prompt", false, "Skip the login prompt if already logged in") TODO: Implement this
593+
// loginCmd.Flags().Bool("skip-prompt", false, "Skip the login prompt if already logged in"); TODO: Implement this
594594
rootCmd.AddCommand(loginCmd)
595595

596596
// Whoami Command
@@ -625,12 +625,12 @@ func main() {
625625
// Compose Command
626626
composeCmd.PersistentFlags().StringP("file", "f", "docker-compose.yml", "Compose file path")
627627
composeCmd.MarkPersistentFlagFilename("file", "yml", "yaml")
628-
// composeCmd.Flags().Bool("compatibility", false, "Run compose in backward compatibility mode") TODO: Implement compose option
629-
// composeCmd.Flags().String("env-file", "", "Specify an alternate environment file.") TODO: Implement compose option
630-
// composeCmd.Flags().Int("parallel", -1, "Control max parallelism, -1 for unlimited (default -1)") TODO: Implement compose option
631-
// composeCmd.Flags().String("profile", "", "Specify a profile to enable") TODO: Implement compose option
632-
// composeCmd.Flags().String("project-directory", "", "Specify an alternate working directory") TODO: Implement compose option
633-
// composeCmd.Flags().StringP("project", "p", "", "Compose project name") TODO: Implement compose option
628+
// composeCmd.Flags().Bool("compatibility", false, "Run compose in backward compatibility mode"); TODO: Implement compose option
629+
// composeCmd.Flags().String("env-file", "", "Specify an alternate environment file."); TODO: Implement compose option
630+
// composeCmd.Flags().Int("parallel", -1, "Control max parallelism, -1 for unlimited (default -1)"); TODO: Implement compose option
631+
// composeCmd.Flags().String("profile", "", "Specify a profile to enable"); TODO: Implement compose option
632+
// composeCmd.Flags().String("project-directory", "", "Specify an alternate working directory"); TODO: Implement compose option
633+
// composeCmd.Flags().StringP("project", "p", "", "Compose project name"); TODO: Implement compose option
634634
composeUpCmd.Flags().Bool("tail", false, "Tail the service logs after updating") // obsolete, but keep for backwards compatibility
635635
composeUpCmd.Flags().Bool("force", false, "Force a build of the image even if nothing has changed")
636636
composeCmd.AddCommand(composeUpCmd)

‎src/pkg/aws/ecs/cfn/template.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ func createTemplate(image string, memory float64, vcpu float64, spot bool, arch
232232
CidrBlock: ptr.String("10.0.0.0/16"),
233233
}
234234
vpcId = cloudformation.RefPtr(_vpc)
235-
// 8b. an internet gateway
235+
// 8b. an internet gateway; FIXME: make internet access optional
236236
const _internetGateway = "InternetGateway"
237237
template.Resources[_internetGateway] = &ec2.InternetGateway{
238238
Tags: append([]tags.Tag{{Key: "Name", Value: prefix + "igw"}}, defaultTags...),
@@ -260,7 +260,7 @@ func createTemplate(image string, memory float64, vcpu float64, spot bool, arch
260260
const _subnet = "Subnet"
261261
template.Resources[_subnet] = &ec2.Subnet{
262262
Tags: append([]tags.Tag{{Key: "Name", Value: prefix + "subnet"}}, defaultTags...),
263-
// AvailabilityZone: TODO: parse region suffix
263+
// AvailabilityZone:; TODO: parse region suffix
264264
CidrBlock: ptr.String("10.0.0.0/20"),
265265
VpcId: cloudformation.Ref(_vpc),
266266
MapPublicIpOnLaunch: ptr.Bool(true),
@@ -295,10 +295,10 @@ func createTemplate(image string, memory float64, vcpu float64, spot bool, arch
295295
IpProtocol: "tcp",
296296
FromPort: ptr.Int(1),
297297
ToPort: ptr.Int(65535),
298-
CidrIp: ptr.String("0.0.0.0/0"), // from anywhere FIXME: restrict to "my ip"
298+
CidrIp: ptr.String("0.0.0.0/0"), // from anywhere; FIXME: make optional and/or restrict to "my ip"
299299
},
300300
},
301-
// SecurityGroupEgress: []ec2.SecurityGroup_Egress{ FIXME: add ability to restrict outbound traffic
301+
// SecurityGroupEgress: []ec2.SecurityGroup_Egress{; FIXME: add ability to restrict outbound traffic
302302
// {
303303
// IpProtocol: "tcp",
304304
// FromPort: ptr.Int(1),

‎src/pkg/aws/ecs/run.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,13 @@ func (a *AwsEcs) Run(ctx context.Context, env map[string]string, cmd ...string)
7474
Overrides: &types.TaskOverride{
7575
// Cpu: ptr.String("256"),
7676
// Memory: ptr.String("512"),
77-
// TaskRoleArn: cred.Arn, TODO: default to caller identity; needs trust + iam:PassRole
77+
// TaskRoleArn: cred.Arn; TODO: default to caller identity; needs trust + iam:PassRole
7878
ContainerOverrides: []types.ContainerOverride{
7979
{
8080
Name: ptr.String(ContainerName),
8181
Command: cmd,
8282
Environment: pairs,
83-
// ResourceRequirements: TODO: make configurable, support GPUs
83+
// ResourceRequirements:; TODO: make configurable, support GPUs
8484
// EnvironmentFiles: ,
8585
},
8686
},

‎src/pkg/cli/compose.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -219,7 +219,7 @@ func convertPorts(ports []types.ServicePortConfig) ([]*pb.Port, error) {
219219
}
220220

221221
func uploadTarball(ctx context.Context, client defangv1connect.FabricControllerClient, body *bytes.Buffer, digest string) (string, error) {
222-
// Upload the tarball to the fabric controller storage TODO: use a streaming API
222+
// Upload the tarball to the fabric controller storage; TODO: use a streaming API
223223
ureq := &pb.UploadURLRequest{Digest: digest}
224224
res, err := client.CreateUploadURL(ctx, connect.NewRequest(ureq))
225225
if err != nil {

‎src/pkg/cli/composeStart.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ func ComposeStart(ctx context.Context, client defangv1connect.FabricControllerCl
200200
//
201201
var services []*pb.Service
202202
for _, svccfg := range project.Services {
203-
// Upload the build context, if any. TODO: parallelize
203+
// Upload the build context, if any; TODO: parallelize
204204
var build *pb.Build
205205
if svccfg.Build != nil {
206206
// Pack the build context into a tarball and upload
@@ -231,7 +231,7 @@ func ComposeStart(ctx context.Context, client defangv1connect.FabricControllerCl
231231
var healthcheck *pb.HealthCheck
232232
if svccfg.HealthCheck != nil && len(svccfg.HealthCheck.Test) > 0 && !svccfg.HealthCheck.Disable {
233233
// if svccfg.HealthCheck.Test[0] == "CMD-SHELL" && len(svccfg.HealthCheck.Test) == 2 {
234-
// // Convert CMD_SHELL to CMD TODO: handle shell quotes and escapes
234+
// // Convert CMD_SHELL to CMD; TODO: handle shell quotes and escapes
235235
// svccfg.HealthCheck.Test = append([]string{"CMD"}, strings.Split(svccfg.HealthCheck.Test[1], " ")...)
236236
// }
237237
healthcheck = &pb.HealthCheck{

‎src/pkg/cli/tail.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ func Tail(ctx context.Context, client defangv1connect.FabricControllerClient, se
8484

8585
if service != "" {
8686
service = NormalizeServiceName(service)
87-
// Show a warning if the service doesn't exist (yet) TODO: could do fuzzy matching and suggest alternatives
87+
// Show a warning if the service doesn't exist (yet); TODO: could do fuzzy matching and suggest alternatives
8888
if _, err := client.Get(ctx, connect.NewRequest(&pb.ServiceID{Name: service})); err != nil {
8989
switch connect.CodeOf(err) {
9090
case connect.CodeNotFound:

‎src/pkg/docker/run.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ func (d Docker) Run(ctx context.Context, env map[string]string, cmd ...string) (
1515
Env: mapToSlice(env),
1616
Cmd: cmd,
1717
}, &container.HostConfig{
18-
AutoRemove: true, // --rm FIXME: this causes "No such container" if the container is exits early
18+
AutoRemove: true, // --rm; FIXME: this causes "No such container" if the container is exits early
1919
PublishAllPorts: true, // -P
2020
Resources: container.Resources{
2121
Memory: int64(d.memory),

‎src/pkg/github/auth.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ func StartAuthCodeFlow(ctx context.Context, clientId string) (string, error) {
144144
"state": {state},
145145
"redirect_uri": {server.URL + "/auth"},
146146
"scope": {"read:org"}, // required for membership check
147-
// "login": {"TODO: from state file"},
147+
// "login": {";TODO: from state file"},
148148
}
149149
authorizeUrl = "https://github.com/login/oauth/authorize?" + values.Encode()
150150

‎src/protos/io/defang/v1/fabric.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/protos/io/defang/v1/fabric.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@ message Service {
240240
string name = 1;
241241
string image = 2;
242242
Platform platform = 3;
243-
bool internal = 4; // true if service is internal TODO: not part of spec
243+
bool internal = 4; // true if service is internal; TODO: not part of spec
244244
Deploy deploy = 5;
245245
repeated Port ports = 6;
246246
map<string, string> environment = 7;

0 commit comments

Comments
 (0)