Skip to content

Commit 9b1e307

Browse files
committed
PR feedback - remove un-used config
1 parent 804f3f4 commit 9b1e307

File tree

3 files changed

+2
-12
lines changed

3 files changed

+2
-12
lines changed

charts/datadog/README.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -474,7 +474,6 @@ helm install <RELEASE_NAME> \
474474
| agents.containers.otelAgent.env | list | `[]` | Additional environment variables for the trace-agent container |
475475
| agents.containers.otelAgent.envDict | object | `{}` | Set environment variables specific to trace-agent defined in a dict |
476476
| agents.containers.otelAgent.envFrom | list | `[]` | Set environment variables specific to trace-agent from configMaps and/or secrets |
477-
| agents.containers.otelAgent.livenessProbe | object | Every 15s | Override default agent liveness probe settings |
478477
| agents.containers.otelAgent.ports | list | `[]` | Allows to specify extra ports (hostPorts for instance) for this container |
479478
| agents.containers.otelAgent.resources | object | `{}` | Resource requests and limits for the trace-agent container |
480479
| agents.containers.otelAgent.securityContext | object | `{}` | Allows you to overwrite the default container SecurityContext for the trace-agent container. |
@@ -772,7 +771,7 @@ helm install <RELEASE_NAME> \
772771
| datadog.osReleasePath | string | `"/etc/os-release"` | Specify the path to your os-release file |
773772
| datadog.otelCollector.config | object | `{}` | OTel collector configuration |
774773
| datadog.otelCollector.enabled | bool | `false` | Enable the OTel Collector |
775-
| datadog.otelCollector.ports | list | `[{"containerPort":"4317","hostPort":"","name":"otel-grpc"},{"containerPort":"4318","hostPort":"","name":"otel-http"}]` | Ports that OTel Collector is listening |
774+
| datadog.otelCollector.ports | list | `[{"containerPort":"4317","name":"otel-grpc"},{"containerPort":"4318","name":"otel-http"}]` | Ports that OTel Collector is listening |
776775
| datadog.otlp.logs.enabled | bool | `false` | Enable logs support in the OTLP ingest endpoint |
777776
| datadog.otlp.receiver.protocols.grpc.enabled | bool | `false` | Enable the OTLP/gRPC endpoint |
778777
| datadog.otlp.receiver.protocols.grpc.endpoint | string | `"0.0.0.0:4317"` | OTLP/gRPC endpoint |

charts/datadog/templates/_container-otel-agent.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
readOnly: false # Need RW for tmp directory
6969
- name: dsdsocket
7070
mountPath: {{ (dir .Values.datadog.dogstatsd.socketPath) }}
71-
readOnly: false # Need RW for UDS DSD socket
71+
readOnly: true
7272
{{- end }}
7373
{{- include "container-crisocket-volumemounts" . | nindent 4 }}
7474
{{- include "container-cloudinit-volumemounts" . | nindent 4 }}

charts/datadog/values.yaml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -529,11 +529,9 @@ datadog:
529529

530530
# Default GRPC port of OTLP receiver
531531
- containerPort: "4317"
532-
hostPort: ""
533532
name: otel-grpc
534533
# Default HTTP port of OTLP receiver
535534
- containerPort: "4318"
536-
hostPort: ""
537535
name: otel-http
538536
# datadog.otelCollector.config -- OTel collector configuration
539537
config: {}
@@ -1692,13 +1690,6 @@ agents:
16921690
# agents.containers.otelAgent.securityContext -- Allows you to overwrite the default container SecurityContext for the trace-agent container.
16931691
securityContext: {}
16941692

1695-
# agents.containers.otelAgent.livenessProbe -- Override default agent liveness probe settings
1696-
# @default -- Every 15s
1697-
livenessProbe:
1698-
initialDelaySeconds: 15
1699-
periodSeconds: 15
1700-
timeoutSeconds: 5
1701-
17021693
# agents.containers.otelAgent.ports -- Allows to specify extra ports (hostPorts for instance) for this container
17031694
ports: []
17041695
traceAgent:

0 commit comments

Comments
 (0)