Apply config overrides to the AgentRuntime layer, not EnvVar (#36519)

Author: dustmop

pkg/config/model/config_overrides.go

@@ -46,7 +46,7 @@ func ApplyOverrideFuncs(config Config) {
 func applyOverrideVars(config Config) {
 	for k, v := range overrideVars {
 		if config.IsKnown(k) {
-			config.Set(k, v, SourceEnvVar)
+			config.Set(k, v, SourceAgentRuntime)
 		}
 	}
 }

pkg/config/setup/config_test.go

@@ -638,6 +638,8 @@ external_config:
 
 	assert.Equal(config.GetString("api_key"), "overrided", "the api key should have been overrided")
 	assert.Equal(config.GetString("dd_url"), "https://app.datadoghq.eu", "this shouldn't be overrided")
+	assert.Equal(config.GetSource("api_key"), pkgconfigmodel.SourceAgentRuntime)
+	assert.Equal(config.GetSource("dd_url"), pkgconfigmodel.SourceFile)
 
 	pkgconfigmodel.AddOverrides(map[string]interface{}{
 		"dd_url": "http://localhost",
@@ -646,6 +648,8 @@ external_config:
 
 	assert.Equal(config.GetString("api_key"), "overrided", "the api key should have been overrided")
 	assert.Equal(config.GetString("dd_url"), "http://localhost", "this dd_url should have been overrided")
+	assert.Equal(config.GetSource("api_key"), pkgconfigmodel.SourceAgentRuntime)
+	assert.Equal(config.GetSource("dd_url"), pkgconfigmodel.SourceAgentRuntime)
 }
 
 func TestGetValidHostAliasesWithConfig(t *testing.T) {