Skip to content

Commit 16fd01c

Browse files
authored
discovery: only init metric when feature is enabled (#36431)
1 parent ded58c0 commit 16fd01c

File tree

2 files changed

+13
-23
lines changed

2 files changed

+13
-23
lines changed

pkg/collector/corechecks/servicediscovery/servicediscovery.go

+13-3
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ import (
1818
"github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/model"
1919
pkgconfigsetup "github.com/DataDog/datadog-agent/pkg/config/setup"
2020
sysprobeclient "github.com/DataDog/datadog-agent/pkg/system-probe/api/client"
21+
"github.com/DataDog/datadog-agent/pkg/telemetry"
2122
"github.com/DataDog/datadog-agent/pkg/util/log"
2223
"github.com/DataDog/datadog-agent/pkg/util/option"
2324
)
@@ -40,8 +41,9 @@ var newOSImpl func() (osImpl, error)
4041
// Check reports discovered services.
4142
type Check struct {
4243
corechecks.CheckBase
43-
os osImpl
44-
sender *telemetrySender
44+
os osImpl
45+
sender *telemetrySender
46+
metricDiscoveredServices telemetry.Gauge
4547
}
4648

4749
// Factory creates a new check factory
@@ -87,6 +89,14 @@ func (c *Check) Configure(senderManager sender.SenderManager, _ uint64, instance
8789
return err
8890
}
8991

92+
c.metricDiscoveredServices = telemetry.NewGaugeWithOpts(
93+
CheckName,
94+
"discovered_services",
95+
[]string{},
96+
"Number of discovered alive services.",
97+
telemetry.Options{NoDoubleUnderscoreSep: true},
98+
)
99+
90100
return nil
91101
}
92102

@@ -98,7 +108,7 @@ func (c *Check) Run() error {
98108
}
99109

100110
log.Debugf("runningServices: %d", response.RunningServicesCount)
101-
metricDiscoveredServices.Set(float64(response.RunningServicesCount))
111+
c.metricDiscoveredServices.Set(float64(response.RunningServicesCount))
102112

103113
for _, p := range response.StartedServices {
104114
c.sender.sendStartServiceEvent(p)

pkg/collector/corechecks/servicediscovery/telemetry.go

-20
This file was deleted.

0 commit comments

Comments
 (0)