Skip to content

feat: add the outputEditorInstance property in panelService #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 9, 2021
Merged

feat: add the outputEditorInstance property in panelService #229

merged 4 commits into from
Jul 9, 2021

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Jul 8, 2021

Description

  1. 增加 outputEditorInstance 属性，方便开发者控制 output editor 对象
  2. 使用 outputEditorInstance 重构 panelService 对output 的操作逻辑

Fixes #128

@wewoor wewoor added the enhancement New feature or request label Jul 8, 2021
@wewoor wewoor added this to the 0.9.0-alpha.3 milestone Jul 8, 2021
@wewoor wewoor self-assigned this Jul 8, 2021
@wewoor wewoor requested a review from mortalYoung July 8, 2021 09:09
mortalYoung
mortalYoung approved these changes Jul 9, 2021
View reviewed changes
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 14ab294 into main Jul 9, 2021
@wewoor wewoor deleted the feat/panel branch July 9, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mortalYoung mortalYoung mortalYoung approved these changes

Assignees

@wewoor wewoor

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.0-alpha.3
Development

Successfully merging this pull request may close these issues.

The Panel Output should export the editorInstance
2 participants
@wewoor @mortalYoung