OrcLib: Ntfs: Compression: Wof: use Parse pattern

Author: fabienfl-orc

src/OrcLib/Filesystem/Ntfs/Attribute/ReparsePoint/WofReparsePoint.cpp

@@ -21,10 +21,10 @@ Result<WofReparsePoint> WofReparsePoint::Parse(BufferView buffer)
         return std::make_error_code(std::errc::message_size);
     }
 
-    return WofReparsePoint(*reinterpret_cast<const WofReparsePoint::Layout*>(buffer.data()));
+    return WofReparsePoint::Parse(*reinterpret_cast<const WofReparsePoint::Layout*>(buffer.data()));
 }
 
-Result<WofReparsePoint> WofReparsePoint::Parse(WofReparsePoint::Layout& layout)
+Result<WofReparsePoint> WofReparsePoint::Parse(const WofReparsePoint::Layout& layout)
 {
     if (layout.version != 1)
     {

src/OrcLib/Filesystem/Ntfs/Attribute/ReparsePoint/WofReparsePoint.h

@@ -37,7 +37,7 @@ class WofReparsePoint
 #pragma pack(pop)
 
     static Result<WofReparsePoint> Parse(BufferView buffer);
-    static Result<WofReparsePoint> Parse(WofReparsePoint::Layout& layout);
+    static Result<WofReparsePoint> Parse(const WofReparsePoint::Layout& layout);
 
     WofReparsePoint(const WofReparsePoint::Layout& header);
 

src/OrcLib/Filesystem/Ntfs/Compression/WofChunks.cpp

@@ -85,7 +85,7 @@ void WofChunks::ParseLocations(BufferView buffer, gsl::span<ChunkLocation> table
     {
         ec = std::make_error_code(std::errc::message_size);
         Log::Debug(
-            "Failed to parse chunk offset table: input buffer is too small (expected: {}, actual: {})",
+            "Failed to parse chunk offset table: input buffer is too small (expected: {}, got: {})",
             expectedBufferSize,
             buffer.size());
         return;
@@ -95,7 +95,7 @@ void WofChunks::ParseLocations(BufferView buffer, gsl::span<ChunkLocation> table
     {
         ec = std::make_error_code(std::errc::message_size);
         Log::Debug(
-            "Failed to parse chunk offset table: output table is too small (expected: {}, actual: {})",
+            "Failed to parse chunk offset table: output table is too small (expected: {}, got: {})",
             m_chunkCount,
             table.size());
         return;

src/OrcLib/Filesystem/Ntfs/Compression/WofStreamConcept.h

@@ -309,7 +309,7 @@ class WofStreamConcept
         if (ec)
         {
             Log::Debug(
-                "Failed to decompress chunk {}/{} (algorithm: {}, chunk size: {}, input size: {}, output size: {}) [{}]",
+                "Failed to decompress chunk {}/{} (algorithm: {}, size: {}, buffer size: {}, output size: {}) [{}]",
                 chunkIndex,
                 m_chunks.ChunkCount(),
                 ToString(m_chunks.Algorithm()),