Place Order controller will hide/overwrite errors from other entries in the chain

[moorena]

cybersource-plugins-rest-salesforceb2ccommerce/cartridges/int_cybs_sfra_base/cartridge/controllers/CheckoutServices.js

Lines 224 to 253 in 2b9ddda

	server.append('PlaceOrder', server.middleware.https, function (req, res, next) {
	// eslint-disable-next-line no-undef
	if (session.privacy.AuthorizeErrors) {
	// eslint-disable-next-line no-undef
	var message = session.privacy.AuthorizeErrors;
	try {
	var messageObject = JSON.parse(message);
	if ('message' in messageObject) {
	message = messageObject.message;
	}
	// eslint-disable-next-line no-empty
	} catch (e) { }
	res.json({
	error: true,
	errorMessage: message
	});
	// eslint-disable-next-line no-undef
	delete session.privacy.AuthorizeErrors;
	} else {
	//For Googlepay and Visa Checkeout Redirect to COPlaceOrder-SubmitOrderConformation.
	res.json({
	error: false,
	ID: session.privacy.orderID,
	token: session.privacy.orderToken,
	continueUrl: URLUtils.url('COPlaceOrder-SubmitOrderConformation').toString()
	});
	}
	return next();
	});

The code here does not respect previous errors -- it does not test viewdata.error/res.error that may have been set in a previous controller in the chain -- and instead will (if there is no authorization errors) overwrite the existing value and claim "no errors". That is ... not good..