Skip to content

Add IDs to manifest #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add IDs to manifest #186

wants to merge 1 commit into from

Conversation

mraible
Copy link
Collaborator

@mraible mraible commented May 14, 2025

Fixes #8.

@mraible mraible requested a review from ssharma12-cs May 14, 2025 14:56
ssharma12-cs
ssharma12-cs approved these changes May 14, 2025
View reviewed changes
Copy link

@ssharma12-cs ssharma12-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please make sure no issues with import, deploy and install steps.

@mraible
Copy link
Collaborator Author

mraible commented May 14, 2025 •
edited
Loading

@ssharma12-cs I tested it with the following plan:

  1. Deploy with CLI
  2. Release with CLI
  3. Install and view; make sure it renders
  4. Delete the app
  5. Import with UI
  6. Release with UI
  7. Install and view, make sure it renders
  8. Delete the app

These all worked. Then, I tried to deploy from the CLI again. This time, I got errors:

❌  Error: failed to deploy app:
	* Invalid Collection - collection resource 84edbef848674d7a8f04260d746eaec9:mitreAutoRemediationJira existed previously, but was deleted
	* Invalid Collection - collection resource 84edbef848674d7a8f04260d746eaec9:mitreAutoRemediationCreatedIssues existed previously, but was deleted

@mraible
Copy link
Collaborator Author

mraible commented May 30, 2025

We've since discovered that this is caused by a bug in Foundry CLI where the foundry ui run command doesn't generate IDs when they're missing.

@mraible mraible closed this May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssharma12-cs ssharma12-cs ssharma12-cs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Readme setup instructions are a little unclear.
2 participants
@mraible @ssharma12-cs