Split icon managers into their own files

Also, add a TODO to have ActionIconManager manage feather icon replacement in renderDialog

Author: Coteh

src/index.ts

@@ -33,7 +33,8 @@ import { AssetManager } from "./manager/asset";
 import { formatTilesetName } from "./util/format";
 import * as marked from "marked";
 import { FullscreenManager } from "./manager/fullscreen";
-import { ActionIconManager, AppIconManager } from "./manager/icon";
+import { ActionIconManager } from "./manager/action-icon";
+import { AppIconManager } from "./manager/app-icon";
 
 import "./styles/global.css";
 

src/manager/action-icon.ts

@@ -0,0 +1,29 @@
+import feather from "feather-icons";
+
+export class ActionIconManager {
+    private iconsLoaded: boolean = false;
+
+    constructor() {
+        this.iconsLoaded = false;
+    }
+
+    public loadIcons() {
+        feather.replace();
+        this.iconsLoaded = true;
+    }
+
+    public changeIcon(parentElement: HTMLElement, newIcon: string) {
+        let childElement = parentElement.querySelector("svg") as HTMLOrSVGElement;
+        if (childElement) {
+            (childElement as SVGElement).remove();
+            childElement = document.createElement("i");
+        } else {
+            childElement = parentElement.querySelector("i") as HTMLElement;
+        }
+        (childElement as HTMLElement).setAttribute("data-feather", newIcon);
+        parentElement.appendChild(childElement as HTMLElement);
+        if (this.iconsLoaded) {
+            feather.replace();
+        }
+    }
+}

src/manager/icon.ts src/manager/app-icon.ts

@@ -1,33 +1,3 @@
-import feather from "feather-icons";
-
-export class ActionIconManager {
-    private iconsLoaded: boolean = false;
-
-    constructor() {
-        this.iconsLoaded = false;
-    }
-
-    public loadIcons() {
-        feather.replace();
-        this.iconsLoaded = true;
-    }
-
-    public changeIcon(parentElement: HTMLElement, newIcon: string) {
-        let childElement = parentElement.querySelector("svg") as HTMLOrSVGElement;
-        if (childElement) {
-            (childElement as SVGElement).remove();
-            childElement = document.createElement("i");
-        } else {
-            childElement = parentElement.querySelector("i") as HTMLElement;
-        }
-        (childElement as HTMLElement).setAttribute("data-feather", newIcon);
-        parentElement.appendChild(childElement as HTMLElement);
-        if (this.iconsLoaded) {
-            feather.replace();
-        }
-    }
-}
-
 export class AppIconManager {
     constructor() {}
 

src/render.ts

@@ -222,6 +222,7 @@ export const renderDialog = (content: HTMLElement, options?: DialogOptions) => {
     overlayBackElem.style.display = "block";
 
     (document.querySelector(".dialog [data-feather='x']") as HTMLElement).innerText = "X";
+    // TODO: ActionIconManager should handle feather.replace()
     feather.replace();
 
     dialog.show();