fix: fix scenario parameters changes loss on file upload

Bug was probably caused by writing/reading during render, it seems to be fixed by using
a lazy-initialization pattern

c.f. facebook/react#18545
c.f. https://reactjs.org/docs/hooks-faq.html#how-to-create-expensive-objects-lazily

Author: csm-thu

src/components/ScenarioParameters/ScenarioParameters.js

@@ -101,34 +101,39 @@ const ScenarioParameters = ({
   );
 
   // Store the reset values for the run template parameters, based on defaultParametersValues and scenario data.
-  const parametersValuesRef = useRef({});
-  parametersValuesRef.current = parametersValuesForReset;
+  const parametersValuesRef = useRef(null);
+  function getParametersValuesRef() {
+    if (parametersValuesRef.current === null) {
+      parametersValuesRef.current = parametersValuesForReset;
+    }
+    return parametersValuesRef.current;
+  }
 
   const generateParametersValuesToRenderFromParametersValuesRef = () => {
     const newParametersValuesToRender = {};
-    for (const parameterId in parametersValuesRef.current) {
+    for (const parameterId in getParametersValuesRef()) {
       if (parametersMetadata[parameterId]?.varType === DATASET_ID_VARTYPE) {
-        const datasetId = parametersValuesRef.current[parameterId];
+        const datasetId = getParametersValuesRef()[parameterId];
         newParametersValuesToRender[parameterId] = FileManagementUtils.buildClientFileDescriptorFromDataset(
           datasets,
           datasetId
         );
       } else {
-        newParametersValuesToRender[parameterId] = parametersValuesRef.current[parameterId];
+        newParametersValuesToRender[parameterId] = getParametersValuesRef()[parameterId];
       }
     }
     return newParametersValuesToRender;
   };
 
-  const setParametersValuesToRenderFromParametersValuesRef = () => {
-    setParametersValuesToRender(generateParametersValuesToRenderFromParametersValuesRef());
-  };
-
   // Add scenario parameters data in state
   const [parametersValuesToRender, setParametersValuesToRender] = useState(
     generateParametersValuesToRenderFromParametersValuesRef()
   );
 
+  const setParametersValuesToRenderFromParametersValuesRef = () => {
+    setParametersValuesToRender(generateParametersValuesToRenderFromParametersValuesRef());
+  };
+
   // Generate input components for each scenario parameters tab
   for (const parametersGroupMetadata of parametersGroupsMetadata) {
     parametersGroupMetadata.tab = ScenarioParametersTabFactory.create(
@@ -154,10 +159,9 @@ const ScenarioParameters = ({
       }
     }
     parametersValuesRef.current = {
-      ...parametersValuesRef.current,
+      ...getParametersValuesRef(),
       ...newParametersValuesToPatch,
     };
-
     await FileManagementUtils.applyPendingOperationsOnFileParameters(
       solution,
       parametersMetadata,
@@ -174,14 +178,15 @@ const ScenarioParameters = ({
   }, [parametersValuesRef]);
 
   useEffect(() => {
+    parametersValuesRef.current = parametersValuesForReset;
     discardLocalChanges();
     // eslint-disable-next-line
   }, [currentScenario]);
 
   const getParametersForUpdate = () => {
     const parametersData = ScenarioParametersUtils.buildParametersForUpdate(
       solution,
-      parametersValuesRef.current,
+      getParametersValuesRef(),
       runTemplateParametersIds
     );
     const additionalParameters = ScenarioParametersUtils.buildAdditionalParameters(currentScenario, scenarioList);