Skip to content

v0.27.0 has broken simulations #887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Anmol1696 opened this issue Jun 9, 2022 · 2 comments
Closed

v0.27.0 has broken simulations #887

Anmol1696 opened this issue Jun 9, 2022 · 2 comments

Comments

@Anmol1696
Copy link

Anmol1696 commented Jun 9, 2022

The simulations seemed to have been fixed recently after the #870 PR, which is not part of the last release tag. Would it be a good idea to create a release tag (v0.27.1) with the fixed simulation (as well as some other updates) if needed.

From my perspective, v0.27.0 is broken, since simulations does not work, hence adding it to testing is not possible.

@alpe
Copy link
Contributor

alpe commented Jun 16, 2022

Thanks for reporting this! Yes, the simulation "operations" are broken in v0.27.0. I had discovered it later when the tag was set already.

Please note that there were no "operations" before and the module was not really contributing to simulations beside some minimal genesis data.. As a quickfix, would it work for you to drop the module from the simulation manger? You would not be loosing much and we could spend our time and effort on the next regular release instead.

@Anmol1696
Copy link
Author

Thanks for the response.

I think it is not actually blocking, since the fix is already in the commits, the quick fix i went for was to pull the wasmd version with the commit instead of the tag.

I would still like to keep the simulations, since I am hoping over time the sims get more robust and people are able to test moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants