Replaces internals button with stamina bar (PentestSS13#122)

<!-- Write **BELOW** The Headers and **ABOVE** The comments else it may
not be viewable. -->
<!-- You can view Contributing.MD for a detailed description of the pull
request process. -->

## About The Pull Request
Ports stamina bar from tg and replaces internals button with it
<!-- Describe The Pull Request. Please be sure every change is
documented or this can delay review and even discourage maintainers from
merging your PR! -->

## Why It's Good For The Game
Makes it easier to see if you are actually dying or if you're just
tired. Internals button isn't really needed considering that you can
just click the o2 tank at top left.
<!-- Please add a short description of why you think these changes would
benefit the game. If you can't justify it in words, it might not be
worth adding. -->

## Changelog

:cl:
add: Ported stamina bar from tg
del: Removed internals button from the hud
/:cl:

<!-- Both :cl:'s are required for the changelog to work! You can put
your name to the right of the first :cl: if you want to overwrite your
GitHub username as author ingame. -->
<!-- You can use multiple of the same prefix (they're only used for the
icon ingame) and delete the unneeded ones. Despite some of the tags,
changelogs should generally represent how a player might be affected by
the changes rather than a summary of the PR's contents. -->

---------

Co-authored-by: KnighTheThrasher <[email protected]>
Co-authored-by: Ossa88 (SYNAPSE) <[email protected]>

Author: KnigTheThrasher

code/_onclick/hud/_defines.dm

@@ -70,7 +70,8 @@
 //Middle right (status indicators)
 #define ui_healthdoll "EAST-1:28,CENTER-2:13"
 #define ui_health "EAST-1:28,CENTER-1:15"
-#define ui_internal "EAST-1:28,CENTER:17"
+//#define ui_internal "EAST-1:28,CENTER:17" //PENTEST REMOVAL
+#define ui_stamina "EAST-1:28,CENTER:17" //PENTEST ADDITION
 #define ui_mood "EAST-1:28,CENTER-3:10"
 
 //Pop-up inventory

code/_onclick/hud/hud.dm

@@ -58,7 +58,8 @@ GLOBAL_LIST_INIT(available_ui_styles, list(
 
 	var/atom/movable/screen/healths
 	var/atom/movable/screen/healthdoll
-	var/atom/movable/screen/internals
+	var/atom/movable/screen/stamina //PENTEST EDIT - START
+	//var/atom/movable/screen/internals //PENTEST EDIT - END
 
 	var/atom/movable/screen/progbar_container/use_timer
 	// subtypes can override this to force a specific UI style
@@ -107,8 +108,9 @@ GLOBAL_LIST_INIT(available_ui_styles, list(
 	QDEL_LIST(infodisplay)
 
 	healths = null
+	stamina = null //PENTEST ADDITION
 	healthdoll = null
-	internals = null
+	//internals = null //PENTEST REMOVAL
 	lingchemdisplay = null
 	lingstingdisplay = null
 	alien_plasma_display = null

code/_onclick/hud/human.dm

@@ -282,9 +282,9 @@
 	rest_icon.hud = src
 	static_inventory += rest_icon
 
-	internals = new /atom/movable/screen/internals()
+/*	internals = new /atom/movable/screen/internals() //PENTEST REMOVAL
 	internals.hud = src
-	infodisplay += internals
+	infodisplay += internals */
 
 	healths = new /atom/movable/screen/healths()
 	healths.hud = src
@@ -294,6 +294,10 @@
 	healthdoll.hud = src
 	infodisplay += healthdoll
 
+	stamina = new /atom/movable/screen/stamina() //PENTEST ADDITION - START
+	stamina.hud = src
+	infodisplay += stamina //PENTEST ADDITION - END
+
 	pull_icon = new /atom/movable/screen/pull()
 	pull_icon.icon = ui_style
 	pull_icon.update_appearance()

code/_onclick/hud/monkey.dm

@@ -89,9 +89,9 @@
 	throw_icon.hud = src
 	hotkeybuttons += throw_icon
 
-	internals = new /atom/movable/screen/internals()
+/*	internals = new /atom/movable/screen/internals() //PENTEST REMOVAL
 	internals.hud = src
-	infodisplay += internals
+	infodisplay += internals*/
 
 	healths = new /atom/movable/screen/healths()
 	healths.hud = src

code/_onclick/hud/screen_objects.dm

@@ -302,7 +302,7 @@
 	icon = 'icons/hud/screen_cyborg.dmi'
 	screen_loc = ui_borg_intents
 
-/atom/movable/screen/internals
+/* /atom/movable/screen/internals //PENTEST REMOVAL
 	name = "toggle internals"
 	icon_state = "internal0"
 	screen_loc = ui_internal
@@ -367,7 +367,7 @@
 		else
 			to_chat(breather, "<span class='warning'>You don't have an oxygen tank!</span>")
 			return
-	breather.update_action_buttons_icon()
+	breather.update_action_buttons_icon()*/
 
 /atom/movable/screen/mov_intent
 	name = "run/walk toggle"

code/game/gamemodes/sandbox/h_sandbox.dm

@@ -175,7 +175,8 @@ GLOBAL_VAR_INIT(hsboxspawn, TRUE)
 				P.back.plane = ABOVE_HUD_PLANE
 				P.update_inv_back()
 				P.internal = P.back
-				P.update_internals_hud_icon(1)
+				P.update_action_buttons_icon() //PENTEST EDIT
+				//P.update_internals_hud_icon(1) //PENTEST REMOVE
 
 			if("hsbscrubber") // This is beyond its normal capability but this is sandbox and you spawned one, I assume you need it
 				var/obj/hsb = new/obj/machinery/portable_atmospherics/scrubber{volume_rate=50*ONE_ATMOSPHERE;on=1}(usr.loc)

code/game/objects/items/tanks/tanks.dm

@@ -33,7 +33,7 @@
 	if(breather.internal == src)
 		to_chat(breather, "<span class='notice'>You close [src] valve.</span>")
 		breather.internal = null
-		breather.update_internals_hud_icon(0)
+		//breather.update_internals_hud_icon(0) //PENTEST REMOVAL
 	else
 		if(!breather.getorganslot(ORGAN_SLOT_BREATHING_TUBE))
 			var/obj/item/clothing/clothes_check = breather.wear_mask
@@ -59,7 +59,7 @@
 		else
 			to_chat(breather, "<span class='notice'>You open [src] valve.</span>")
 		breather.internal = src
-		breather.update_internals_hud_icon(1)
+		//breather.update_internals_hud_icon(1) //PENTEST REMOVAL
 	breather.update_action_buttons_icon()
 
 

code/modules/mob/living/carbon/carbon.dm

@@ -206,11 +206,13 @@
 			if(do_after(usr, POCKET_STRIP_DELAY, src))
 				if(internal)
 					internal = null
-					update_internals_hud_icon(0)
+					//update_internals_hud_icon(0) //PENTEST EDIT
+					update_action_buttons_icon()
 				else if(ITEM && istype(ITEM, /obj/item/tank))
 					if((wear_mask && (wear_mask.clothing_flags & ALLOWINTERNALS)) || getorganslot(ORGAN_SLOT_BREATHING_TUBE))
 						internal = ITEM
-						update_internals_hud_icon(1)
+						//update_internals_hud_icon(1)
+						update_action_buttons_icon() //PENTEST EDIT
 
 				visible_message("<span class='danger'>[usr] [internal ? "opens" : "closes"] the valve on [src]'s [ITEM.name].</span>", \
 								"<span class='userdanger'>[usr] [internal ? "opens" : "closes"] the valve on your [ITEM.name].</span>", null, null, usr)
@@ -543,7 +545,7 @@
 		REMOVE_TRAIT(src, TRAIT_HANDS_BLOCKED, STAMINA)
 	else
 		return
-	update_health_hud()
+	update_stamina_hud() //PENTEST EDIT HEALTH TO STAMINA
 
 /mob/living/carbon/update_sight()
 	if(!client)
@@ -768,9 +770,9 @@
 		else
 			hud_used.healths.icon_state = "health7"
 
-/mob/living/carbon/proc/update_internals_hud_icon(internal_state = 0)
+/*/mob/living/carbon/proc/update_internals_hud_icon(internal_state = 0) //PENTEST REMOVAL
 	if(hud_used && hud_used.internals)
-		hud_used.internals.icon_state = "internal[internal_state]"
+		hud_used.internals.icon_state = "internal[internal_state]"*/
 
 /*WS revert
 /mob/living/carbon/proc/update_spacesuit_hud_icon(cell_state = "empty")
@@ -810,6 +812,7 @@
 			set_stat(CONSCIOUS)
 	update_damage_hud()
 	update_health_hud()
+	update_stamina_hud()
 	med_hud_set_status()
 
 

code/modules/mob/living/carbon/human/human.dm

@@ -843,8 +843,9 @@
 		return
 	else
 		if(hud_used.healths)
-			var/health_amount = min(health, maxHealth - getStaminaLoss())
-			if(..(health_amount)) //not dead
+			if(..()) //not dead
+/*			var/health_amount = min(health, maxHealth - getStaminaLoss()) //PENTEST EDIT
+			if(..(health_amount))*/
 				switch(hal_screwyhud)
 					if(SCREWYHUD_CRIT)
 						hud_used.healths.icon_state = "health6"

code/modules/mob/living/carbon/human/inventory.dm

@@ -317,7 +317,8 @@
 	if((I.flags_inv & (HIDEHAIR|HIDEFACIALHAIR)) || (initial(I.flags_inv) & (HIDEHAIR|HIDEFACIALHAIR)))
 		update_hair()
 	if(toggle_off && internal && !getorganslot(ORGAN_SLOT_BREATHING_TUBE))
-		update_internals_hud_icon(0)
+		update_action_buttons_icon() //PENTEST EDIT
+		//update_internals_hud_icon(0)
 		internal = null
 	if(I.flags_inv & HIDEEYES)
 		update_inv_glasses()

code/modules/mob/living/carbon/human/species_types/plasmamen.dm

@@ -184,7 +184,8 @@
 
 	H.equipOutfit(O, visualsOnly)
 	H.internal = H.get_item_for_held_index(2)
-	H.update_internals_hud_icon(1)
+	H.update_action_buttons_icon()
+	//H.update_internals_hud_icon(1) //PENTEST EDIT
 	return 0
 
 /datum/species/plasmaman/random_name(gender,unique,lastname)

code/modules/mob/living/carbon/life.dm

@@ -288,12 +288,15 @@
 	if(internal)
 		if(internal.loc != src)
 			internal = null
-			update_internals_hud_icon(0)
+			update_action_buttons_icon() //PENTEST EDIT
+			//update_internals_hud_icon(0)
 		else if (!internals && !getorganslot(ORGAN_SLOT_BREATHING_TUBE)) //WS Port - Citadel Internals
 			internal = null
-			update_internals_hud_icon(0)
+			update_action_buttons_icon() //PENTEST EDIT
+			//update_internals_hud_icon(0)
 		else
-			update_internals_hud_icon(1)
+			update_action_buttons_icon() //PENTEST EDIT
+			//update_internals_hud_icon(1)
 			. = internal.remove_air_volume(volume_needed)
 			if(!.)
 				return FALSE //to differentiate between no internals and active, but empty internals

modular_pentest/master_files/code/_onclick/hud/screen_objects.dm

@@ -0,0 +1,6 @@
+/atom/movable/screen/stamina
+	icon = 'modular_pentest/master_files/icons/hud/screen_gen.dmi'
+	name = "stamina"
+	icon_state = "stamina0"
+	screen_loc = ui_stamina
+

modular_pentest/master_files/code/modules/mob/living/carbon/carbon.dm

@@ -0,0 +1,27 @@
+/mob/living/carbon/update_stamina_hud(shown_stamina_loss)
+	if(!client || !hud_used?.stamina)
+		return
+
+	var/stam_crit_threshold = maxHealth - crit_threshold
+
+	if(stat == DEAD)
+		hud_used.stamina.icon_state = "stamina_dead"
+	else
+
+		if(shown_stamina_loss == null)
+			shown_stamina_loss = getStaminaLoss()
+
+		if(shown_stamina_loss >= stam_crit_threshold)
+			hud_used.stamina.icon_state = "stamina_crit"
+		else if(shown_stamina_loss > maxHealth*0.8)
+			hud_used.stamina.icon_state = "stamina_5"
+		else if(shown_stamina_loss > maxHealth*0.6)
+			hud_used.stamina.icon_state = "stamina_4"
+		else if(shown_stamina_loss > maxHealth*0.4)
+			hud_used.stamina.icon_state = "stamina_3"
+		else if(shown_stamina_loss > maxHealth*0.2)
+			hud_used.stamina.icon_state = "stamina_2"
+		else if(shown_stamina_loss > 0)
+			hud_used.stamina.icon_state = "stamina_1"
+		else
+			hud_used.stamina.icon_state = "stamina_full"

modular_pentest/master_files/code/modules/mob/mob.dm

@@ -0,0 +1,3 @@
+/// Changes the stamina HUD based on new information
+/mob/proc/update_stamina_hud()
+	return

modular_pentest/master_files/icons/hud/screen_gen.dmi

@@ -107,6 +107,9 @@
 #include "master_files\code\modules\language\language_holder.dm"
 #include "master_files\code\modules\mining\lavaland\necropolis_chests.dm"
 #include "master_files\code\modules\mining\machine_vending.dm"
+#include "master_files\code\_onclick\hud\screen_objects.dm"
+#include "master_files\code\modules\mob\living\carbon\carbon.dm"
+#include "master_files\code\modules\mob\mob.dm"
 #include "master_files\code\modules\mob\dead\new_player\ship_select.dm"
 #include "master_files\code\modules\mob\dead\observer\observer.dm"
 #include "master_files\code\modules\mob\living\carbon\human\species_types\jellypeople.dm"