Skip to content

Commit de165b5

Browse files
Fix usage of actions/*-artifacts@v4 in CI (#2)
## Summary of the Pull Request It appear that the behaviour of the `upload-artifact` action was changed between `v3` and `v4` and that implicitly merging content by invoking the `upload-artifact` action with the same artifact name and different paths is not supported anymore. This PR attempt to resolve the issue by applying the changes suggested in actions/upload-artifact#480 (comment) Related - actions/upload-artifact#480 - https://github.com/actions/download-artifact#download-multiple-filtered-artifacts-to-the-same-directory
1 parent 0fef21d commit de165b5

File tree

1 file changed

+6
-15
lines changed

1 file changed

+6
-15
lines changed

.github/workflows/main.yml

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@ jobs:
120120
- name: Upload artifacts
121121
uses: actions/upload-artifact@v4
122122
with:
123-
name: dist
123+
name: dist-base
124124
path: dist
125125

126126
build-windows:
@@ -143,8 +143,9 @@ jobs:
143143
- name: Download artifacts
144144
uses: actions/download-artifact@v4
145145
with:
146-
name: dist
146+
pattern: dist-*
147147
path: dist
148+
merge-multiple: true
148149

149150
- name: Setup dotnet SDK
150151
uses: actions/setup-dotnet@v4
@@ -173,7 +174,7 @@ jobs:
173174
- name: Upload artifacts
174175
uses: actions/upload-artifact@v4
175176
with:
176-
name: dist
177+
name: dist-installer
177178
path: dist-installer
178179

179180
release:
@@ -197,8 +198,9 @@ jobs:
197198
- name: Download artifacts
198199
uses: actions/download-artifact@v4
199200
with:
200-
name: dist
201+
pattern: dist-*
201202
path: dist
203+
merge-multiple: true
202204

203205
- name: Create hashes
204206
shell: bash
@@ -215,14 +217,3 @@ jobs:
215217
dist/ContainerDesktopInstaller.exe
216218
dist/ContainerDesktopInstaller.zip
217219
dist/sha256sum.txt
218-
219-
220-
221-
222-
223-
224-
225-
226-
227-
228-

0 commit comments

Comments
 (0)