Skip to content

Commit 3f0522c

Browse files
committed
This step could be simplified or removed if pip could report the version of the package it was about to install. See pypa/pip#53
1 parent 75725ee commit 3f0522c

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

admin/packaging.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,11 @@ class GetPackageVersion(object):
172172
Record the version of ``package_name`` installed in ``virtualenv_path`` by
173173
parsing the output of ``pip show``.
174174
175+
XXX: This wouldn't be necessary if pip had a way to report the version of
176+
the package that it is about to install eg
177+
``pip install --dry-run http://www.example.com/my/wheel.whl``
178+
See: https://github.com/pypa/pip/issues/53
179+
175180
:ivar FilePath virtualenv_path: The path of the ``virtualenv`` containing
176181
the package.
177182
:ivar bytes package_name: The name of the package whose version will be

0 commit comments

Comments
 (0)