Code Quality: Fix pylint warnings for analytics app(#4558)

* Pylint Score increased for apps/analytics/serializers.py

* Pylint Score increased for apps/analytics/views.py

* Pylint Score increased for apps/analytics/urls.py

* Conflicts Resolved

* Revert "Conflicts Resolved"

This reverts commit c8f533c.

* Conflicts Resolved

* Conflicts Resolved

* Conflicts Resolved

* Conflicts Resolved

* Conflicts Resolved

* Fixed Build

* Resolved Conflict

* Removed Unnecessary Changes

* Black Fix

* Black Fix

* Black Fix

* Made Changes

---------

Co-authored-by: Akshat Singh <[email protected]>
Co-authored-by: Rishabh Jain <[email protected]>

Author: 3 people

apps/analytics/serializers.py

@@ -1,7 +1,8 @@
 from rest_framework import serializers
 
 
-class ChallengePhaseSubmissionAnalytics(object):
+class ChallengePhaseSubmissionAnalytics:
+    # pylint: disable=too-many-arguments
     def __init__(
         self,
         total_submissions,
@@ -25,7 +26,7 @@ class ChallengePhaseSubmissionAnalyticsSerializer(serializers.Serializer):
     challenge_phase = serializers.IntegerField()
 
 
-class ChallengePhaseSubmissionCount(object):
+class ChallengePhaseSubmissionCount:
     def __init__(self, participant_team_submission_count, challenge_phase_pk):
         self.participant_team_submission_count = (
             participant_team_submission_count
@@ -38,7 +39,7 @@ class ChallengePhaseSubmissionCountSerializer(serializers.Serializer):
     challenge_phase = serializers.IntegerField()
 
 
-class LastSubmissionTimestamp(object):
+class LastSubmissionTimestamp:
     def __init__(
         self,
         last_submission_timestamp_in_challenge,

apps/analytics/urls.py

@@ -1,46 +1,46 @@
-from django.conf.urls import url
+from django.urls import re_path
 
 from . import views
 
 urlpatterns = [
-    url(
+    re_path(
         r"^challenge/(?P<challenge_pk>[0-9]+)/team/count$",
         views.get_participant_team_count,
         name="get_participant_team_count",
     ),
-    url(
+    re_path(
         r"^challenge/(?P<challenge_pk>[0-9]+)/participant/count$",
         views.get_participant_count,
         name="get_participant_count",
     ),
-    url(
+    re_path(
         r"^challenge/(?P<challenge_pk>[0-9]+)/submission/(?P<duration>[A-Za-z]+)/count$",
         views.get_submission_count,
         name="get_submission_count",
     ),
-    url(
+    re_path(
         r"^challenge/(?P<challenge_pk>[0-9]+)/challenge_phase/(?P<challenge_phase_pk>[0-9]+)/analytics$",
         views.get_challenge_phase_submission_analysis,
         name="get_challenge_phase_submission_analysis",
     ),
-    url(
+    re_path(
         r"^challenge/(?P<challenge_pk>[0-9]+)/challenge_phase/(?P<challenge_phase_pk>[0-9]+)/count$",
         views.get_challenge_phase_submission_count_by_team,
         name="get_challenge_phase_submission_count_by_team",
     ),
-    url(
+    re_path(
         r"^challenge/(?P<challenge_pk>[0-9]+)/challenge_phase/"
         r"(?P<challenge_phase_pk>[0-9]+)/last_submission/(?P<submission_by>[A-Za-z_]+)$",
         views.get_last_submission_time,
         name="get_last_submission_time",
     ),
-    url(
+    re_path(
         r"^challenge/(?P<challenge_pk>[0-9]+)/challenge_phase/"
         r"(?P<challenge_phase_pk>[0-9]+)/last_submission_datetime_analysis/$",
         views.get_last_submission_datetime_analysis,
         name="get_last_submission_datetime_analysis",
     ),
-    url(
+    re_path(
         r"^challenges/(?P<challenge_pk>[0-9]+)/download_all_participants/$",
         views.download_all_participants,
         name="download_all_participants",

apps/analytics/views.py

@@ -205,9 +205,8 @@ def get_last_submission_time(
         serializer = LastSubmissionDateTimeSerializer(last_submitted_at)
         return Response(serializer.data, status=status.HTTP_200_OK)
 
-    else:
-        response_data = {"error": "Page not found!"}
-        return Response(response_data, status=status.HTTP_404_NOT_FOUND)
+    response_data = {"error": "Page not found!"}
+    return Response(response_data, status=status.HTTP_404_NOT_FOUND)
 
 
 @api_view(["GET"])
@@ -358,8 +357,8 @@ def download_all_participants(request, challenge_pk):
                 ]
             )
         return response
-    else:
-        response_data = {
-            "error": "Sorry, you are not authorized to make this request"
-        }
-        return Response(response_data, status=status.HTTP_400_BAD_REQUEST)
+
+    response_data = {
+        "error": "Sorry, you are not authorized to make this request"
+    }
+    return Response(response_data, status=status.HTTP_400_BAD_REQUEST)