Gg/release 0 8 9 (#434)

* Roll back timezone deprecation

* Remove unused function aliases

Author: genzgd

CHANGELOG.md

@@ -11,6 +11,13 @@ release (0.9.0), unrecognized arguments/keywords for these methods of creating a
 instead of being passed as ClickHouse server settings. This is in conjunction with some refactoring in Client construction.
 The supported method of passing ClickHouse server settings is to prefix such arguments/query parameters with`ch_`.
 
+## 0.8.9, 2024-12-02
+### Bug Fix
+- Roll back some timezone changes that caused incorrect usage of "local time" objects for some ClickHouse queries.  Note that
+has deprecated "naive" timestamps; however converting everything to timezone aware objects (with the UTC timezone as appropriate)
+causes some numpy and possibly Pandas side effects.  Eventually naive datetime object support will be deprecated/eliminated,
+but it will take some time to ensure no breaking changes.  Fixes https://github.com/ClickHouse/clickhouse-connect/issues/433
+
 ## 0.8.8, 2024-11-27
 ### Improvement
 - Handle low level HTTP errors as "Stream Complete".  This provides better compatibility with the most recent

clickhouse_connect/__version__.py

@@ -1 +1 @@
-version = '0.8.8'
+version = '0.8.9'

clickhouse_connect/datatypes/temporal.py

@@ -79,9 +79,6 @@ def _read_column_binary(self, source: ByteSource, num_rows: int, ctx: QueryConte
         return data_conv.read_date32_col(source, num_rows)
 
 
-from_ts_tz = datetime.fromtimestamp
-
-
 class DateTimeBase(ClickHouseType, registered=False):
     __slots__ = ('tzinfo',)
     valid_formats = 'native', 'int'
@@ -192,7 +189,7 @@ def _read_binary_tz(self, column: Sequence, tz_info: tzinfo):
     def _read_binary_naive(self, column: Sequence):
         new_col = []
         app = new_col.append
-        dt_from = datetime.fromtimestamp
+        dt_from = datetime.utcfromtimestamp
         prec = self.prec
         for ticks in column:
             seconds = ticks // prec

clickhouse_connect/driver/dataconv.py

@@ -28,6 +28,9 @@ def read_ipv4_col(source: ByteSource, num_rows: int):
 
 def read_datetime_col(source: ByteSource, num_rows: int, tz_info: Optional[tzinfo]):
     src_array = source.read_array('I', num_rows)
+    if tz_info is None:
+        fts = datetime.utcfromtimestamp
+        return [fts(ts) for ts in src_array]
     fts = datetime.fromtimestamp
     return [fts(ts, tz_info) for ts in src_array]
 

clickhouse_connect/tools/datagen.py

@@ -18,7 +18,8 @@
 from clickhouse_connect.datatypes.temporal import Date, Date32, DateTime, DateTime64
 from clickhouse_connect.driver.common import array_sizes
 
-dt_from_ts = datetime.fromtimestamp
+dt_from_ts = datetime.utcfromtimestamp
+dt_from_ts_tz = datetime.fromtimestamp
 epoch_date = date(1970, 1, 1)
 date32_start_date = date(1925, 1, 1)
 
@@ -137,7 +138,7 @@ def random_datetime():
 
 
 def random_datetime_tz(timezone: tzinfo):
-    return dt_from_ts(int(random() * 2 ** 32), timezone).replace(microsecond=0)
+    return dt_from_ts_tz(int(random() * 2 ** 32), timezone).replace(microsecond=0)
 
 
 def random_ascii_str(max_len: int = 200, min_len: int = 0):
@@ -171,7 +172,7 @@ def random_datetime64_tz(prec: int, timezone: tzinfo):
         u_sec = int(random() * 1000) * 1000
     else:
         u_sec = int(random() * 1000000)
-    return dt_from_ts(int(random() * 4294967296), timezone).replace(microsecond=u_sec)
+    return dt_from_ts_tz(int(random() * 4294967296), timezone).replace(microsecond=u_sec)
 
 
 def random_ipv6():