Skip to content

Use less defaults in model construction? #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ali-ramadhan opened this issue Oct 11, 2019 · 1 comment · Fixed by #614
Closed

Use less defaults in model construction? #459

ali-ramadhan opened this issue Oct 11, 2019 · 1 comment · Fixed by #614
Labels
cleanup 🧹 Paying off technical debt

Comments

@ali-ramadhan
Copy link
Member

ali-ramadhan commented Oct 11, 2019

@johncmarshall54 suggested it might be a bit dangerous to assume default boundary conditions, so they should always be specified.

Worth discussing as this might apply to other model properties too.

A common question for simple model setups is "what are the boundary conditions?".

@ali-ramadhan ali-ramadhan added the cleanup 🧹 Paying off technical debt label Oct 11, 2019
@ali-ramadhan ali-ramadhan changed the title Use less default in model construction Use less defaults in model construction Oct 11, 2019
@ali-ramadhan ali-ramadhan changed the title Use less defaults in model construction Use less defaults in model construction? Oct 18, 2019
@glwagner
Copy link
Member

glwagner commented Feb 4, 2020

I am fine either way. Documentation is the important part in my opinion. In general, I think defaults are important for useability. However, if using a default isn't helpful for useability, then I agree it should be avoided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants