Skip to content

HydrostaticFreeSurfaceModel regression tests are quite narrow #4194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
glwagner opened this issue Mar 10, 2025 · 1 comment
Open

HydrostaticFreeSurfaceModel regression tests are quite narrow #4194

glwagner opened this issue Mar 10, 2025 · 1 comment
Labels
testing 🧪 Tests get priority in case of emergency evacuation

Comments

@glwagner
Copy link
Member

We may want to regression test a bit more, including various combination of WENOVectorInvariant and advection schemes. Once the TripolarGrid is merged, we likely want something on that grid too.

Right now I believe only the grid and free surface are varied:

Oceananigans.jl/test/test_hydrostatic_regression.jl

Line 93 in 40e0a87

run_hydrostatic_free_turbulence_regression_test(grid, free_surface)

For context, @luraess and I have observed some modulation in the outcome of a baroclinic instability test between 0.95.12 and main

v0.95.12...main
@glwagner glwagner added the testing 🧪 Tests get priority in case of emergency evacuation label Mar 10, 2025
@glwagner
Copy link
Member Author

glwagner commented Mar 10, 2025 •
edited
Loading

In particular this commit may be causing a problem right now: 583dcd2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@glwagner