Update talk_tags.json

[XingXingMonkeyGrandma]

Summary

Improved snippets.

Purpose of change

Many the snippets in this file didn't feel right to me. They were either juvenile, whimsical, or (for some reason) British. I have changed them in such a way that they feel more accurate to the way actual people talk, at least to my ear.

Describe the solution

Edited text.

Describe alternatives you've considered

Leaving alone.

Testing

N/A

Additional context

The suitability of any such changes is bound to be subjective to some degree. I've chosen to trust my own ear as someone who lives on the east coast in the absence of objective criteria. I've also erred on the side of quality rather than quantity. I think I've improved things in general, but particular inclusions and exclusions are of course up for debate.

[github-actions]

[JSON & C++ formatters] _{reported by reviewdog 🐶}

Suggested change

	"text": [
	"accomplice",
	"adventurer",
	"amigo",
	"bruv",
	"boss",
	"bro",
	"brother",
	"bud",
	"buddy",
	"chum",
	"comrade",
	"fella",
	"fellow survivor",
	"fellow traveler",
	"friend",
	"lad",
	"loyal friend",
	"mate",
	"my brother-in-arms",
	"my dude",
	"my fellow nomad",
	"my fellow wanderer",
	"my good fellow",
	"pal",
	"partner",
	"trusty companion"
	"dude",
	"man",
	"my guy",
	"my man",
	"pal"
	]
	"text": [ "boss", "bro", "brother", "bud", "buddy", "dude", "man", "my guy", "my man", "pal" ]

[github-actions]

[JSON & C++ formatters] _{reported by reviewdog 🐶}

Suggested change

	"text": [
	"living corpse",
	"goo-puker",
	"shambler",
	"undead",
	"walker",
	"walking corpse",
	{ "text": { "ctxt": "<zombie>", "str": "Z" } },
	"zed",
	"zombie"
	]
	"text": [ "undead", "walking corpse", "zombie" ]

[Maleclypse]

No to the deletions. Stop changing the comments explaining the text to as if it is the text itself. Cataclysm is always capitalized. Once there is less red I’ll try and review the actual dialogue changes.

[XingXingMonkeyGrandma]

I don't know what you're referring to. I changed some example text to match the changes. What exactly is the problem with the deletions? NPCs need to be able to say "bellend" and "fuck-trumpet?"

[Maleclypse]

Suggested change

	"//": "A threat is on the horizon: '[It's a zombie east,] way out in the distance.'",
	"//": "A threat is on the horizon: '[It's a zombie east,] way out in the distance.'",

These "//" are explanatory comments to help translators they don't need to exactly match the text.

[XingXingMonkeyGrandma]

It seems like matching the text makes it more clear, or at the very least not less so

[Maleclypse]

I don't know what you're referring to. I changed some example text to match the changes. What exactly is the problem with the deletions? NPCs need to be able to say "bellend" and "fuck-trumpet?"

Here's the deal if you have very specific ones you want to get rid of please feel free to show me, if you have 150 lines you've decided to eliminate I'm not going to review every single one of them to decide whether I think you are cutting too deeply because you are cutting too deeply already.

[Maleclypse]

To put it bluntly people say juvenile and puerile things and I'd rather have too many snippets and some that people never see rather than 20 lines that keep repeating every single playthrough.

[XingXingMonkeyGrandma]

I don't know what you're referring to. I changed some example text to match the changes. What exactly is the problem with the deletions? NPCs need to be able to say "bellend" and "fuck-trumpet?"

Here's the deal if you have very specific ones you want to get rid of please feel free to show me, if you have 150 lines you've decided to eliminate I'm not going to review every single one of them to decide whether I think you are cutting too deeply because you are cutting too deeply already.

I don't understand. Is it impossible that the majority of these snippets could have been inadequate? I don't see how the volume of change invalidates said change. I can spend weeks making very many pull requests justifying each deletion but it would be a tedious waste of time all around

[XingXingMonkeyGrandma]

To put it bluntly people say juvenile and puerile things and I'd rather have too many snippets and some that people never see rather than 20 lines that keep repeating every single playthrough.

You will never hear anyone in New England use any of the deleted entries. You do actually hear a lot of repetition IRL. Profanity doesn't need creativity, it's supposed to be simple. If these are meant to be "generic" then you should expect a degree of repetition either way.

I can add more if this is a sticking point but I stand by every single deletion

[Maleclypse]

For example, your change right here makes every one of the snippets you've added and/or left behind no longer appear anywhere and breaks NPC dialogue. You are making changes without understanding the consequences of what you are doing.

[XingXingMonkeyGrandma]

That's a clear mistake that I'm happy to fix but if you're going to overgeneralize a technical error to cast doubt on stylistic dialogue changes then I'm going to push back

[kevingranade]

At a glance you're removing a TON of lines that should stay in. I'd say your throwing out the baby with the bathwater, but it's not clear that it's not all baby.

Cut it down to where it's reviewable and someone can spend a reasonable amount of time reviewing it and giving you feedback, whichwill include a lot of "no this stays". If you're presenting this as take it or leave it, we're leaving it.

[XingXingMonkeyGrandma]

At a glance you're removing a TON of lines that should stay in. I'd say your throwing out the baby with the bathwater, but it's not clear that it's not all baby.

Cut it down to where it's reviewable and someone can spend a reasonable amount of time reviewing it and giving you feedback, whichwill include a lot of "no this stays". If you're presenting this as take it or leave it, we're leaving it.

I want you to imagine an angry grown adult in a post-apocalypse calling you a "freaking dumb head" or whatever and ask yourself whether that seems right. (It might seem right for a specific sort of person, but we're considering a randomly selected person). I guess I don't understand what makes these valuable beyond the fact that they exist

[XingXingMonkeyGrandma]

I want to add here that presumably every NPC pulls from this pool and that in many cases many of these will sound completely dissonant or weird depending on the character in question

[kevingranade]

Feel free to try again if you feel like following the feedback you've received.