Remove the vehicle movement volume test

The test is obviously failing since the aisle's cargo size changed. This is something the test basically is intended to catch (to make sure that moving through an aisle is/isn't cramped) but it... no longer makes sense in the context of what we're doing. We turned off the inability to move through vehicle tiles based on size some time ago, and I don't see it coming back on anytime soon.

Making it a test-specific object doesn't really help the test do what it's supposed to do. Marking it mayfail is not sufficient, it will continue to produce debugmsg and flag the github CI as failed.

Therefore, my approach is to delete the test altogether.

Author: RenechCDDA

tests/char_volume_test.cpp

@@ -12,16 +12,11 @@
 #include "units.h"
 #include "vpart_position.h"
 
-static const itype_id itype_backpack_giant( "backpack_giant" );
-static const itype_id itype_rock_volume_test( "rock_volume_test" );
-
 static const trait_id trait_HUGE( "HUGE" );
 static const trait_id trait_LARGE( "LARGE" );
 static const trait_id trait_SMALL( "SMALL" );
 static const trait_id trait_SMALL2( "SMALL2" );
 
-static const vproto_id vehicle_prototype_character_volume_test_car( "character_volume_test_car" );
-
 static units::volume your_volume_with_trait( trait_id new_trait )
 {
     clear_avatar();
@@ -60,61 +55,3 @@ TEST_CASE( "character_baseline_volumes", "[volume]" )
     REQUIRE( your_height_with_trait( trait_HUGE ) == 280 );
     CHECK( your_volume_with_trait( trait_HUGE ) == 156228_ml );
 }
-
-TEST_CASE( "character_at_volume_will_be_cramped_in_vehicle", "[volume]" )
-{
-    clear_avatar();
-    clear_map();
-    map &here = get_map();
-    Character &you = get_player_character();
-    REQUIRE( you.get_mutations().empty() );
-
-    tripoint_bub_ms test_pos {10, 10, 0 };
-
-
-    clear_vehicles(); // extra safety
-    here.add_vehicle( vehicle_prototype_character_volume_test_car, test_pos, 0_degrees, 0, 0 );
-    you.setpos( here, test_pos );
-    const optional_vpart_position vp_there = here.veh_at( you.pos_bub( here ) );
-    REQUIRE( vp_there );
-    tripoint_abs_ms dest_loc = you.pos_abs();
-
-    // Empty aisle
-    dest_loc = dest_loc + tripoint::north_west;
-    CHECK( !you.will_be_cramped_in_vehicle_tile( here, dest_loc ) );
-    dest_loc = you.pos_abs(); //reset
-
-    // Aisle with 10L rock, a tight fit but not impossible
-    dest_loc = dest_loc + tripoint::north;
-    CHECK( you.will_be_cramped_in_vehicle_tile( here, dest_loc ) );
-    dest_loc = you.pos_abs(); //reset
-
-    // Empty aisle, but we've put on a backpack and a 10L rock in that backpack
-    item backpack( itype_backpack_giant );
-    auto worn_success = you.wear_item( backpack );
-    CHECK( worn_success );
-    you.i_add( item( itype_rock_volume_test ) );
-    CHECK( 75_liter <= you.get_total_volume() );
-    CHECK( you.get_total_volume() <= 100_liter );
-    dest_loc = dest_loc + tripoint::north_west;
-    CHECK( you.will_be_cramped_in_vehicle_tile( here, dest_loc ) );
-    dest_loc = you.pos_abs(); //reset
-
-    // Try the cramped aisle with a rock again, but now we are tiny, so it is easy.
-    CHECK( your_volume_with_trait( trait_SMALL2 ) == 23326_ml );
-    you.setpos( here, test_pos ); // set our position again, clear_avatar() moved us
-    dest_loc = dest_loc + tripoint::north;
-    CHECK( !you.will_be_cramped_in_vehicle_tile( here, dest_loc ) );
-    dest_loc = you.pos_abs(); //reset
-
-    // Same aisle, but now we have HUGE GUTS. We will never fit.
-    CHECK( your_volume_with_trait( trait_HUGE ) == 156228_ml );
-    you.setpos( here, test_pos ); // set our position again, clear_avatar() moved us
-    dest_loc = dest_loc + tripoint::north;
-    CHECK( you.will_be_cramped_in_vehicle_tile( here, dest_loc ) );
-    dest_loc = you.pos_abs(); //reset
-
-    // And finally, check that our HUGE body won't fit even into an empty aisle.
-    dest_loc = dest_loc + tripoint::north_west;
-    CHECK( you.will_be_cramped_in_vehicle_tile( here, dest_loc ) );
-}