SIMPLE-7433 show all running nodes in compute hosts sysadmin (#146)

* SIMPLE-7433 nodes_count added to compute

* SIMPLE-7433 nodes_count renamed to node_counts

* Deprecated the nodes property

---------

Co-authored-by: Tomas Mikuska <[email protected]>

Author: marpauli-cisco

virl2_client/models/lab.py

@@ -2135,7 +2135,8 @@ def update_lab_groups(
         :returns: Updated objects consisting of group ID and permissions.
         """
         warnings.warn(
-            "'Lab.update_lab_groups()' is deprecated. Use '.update_associations()' instead.",
+            "'Lab.update_lab_groups()' is deprecated. Use '.update_associations()'"
+            " instead.",
             DeprecationWarning,
         )
         url = self._url_for("lab")

virl2_client/models/system.py

@@ -23,6 +23,7 @@
 import logging
 import time
 from typing import TYPE_CHECKING, Any
+import warnings
 
 from virl2_client.exceptions import ControllerNotFound
 
@@ -297,6 +298,7 @@ def add_compute_host_local(
         is_connected: bool,
         is_synced: bool,
         admission_state: str,
+        node_counts: dict[str, int],
         nodes: list[str] | None = None,
     ) -> ComputeHost:
         """
@@ -310,6 +312,7 @@ def add_compute_host_local(
         :param is_connected: A boolean indicating if the compute host is connected.
         :param is_synced: A boolean indicating if the compute host is synced.
         :param admission_state: The admission state of the compute host.
+        :param node_counts: Count of deployed and running nodes and orphans.
         :param nodes: A list of node IDs associated with the compute host.
         :returns: The added compute host.
         """
@@ -323,6 +326,7 @@ def add_compute_host_local(
             is_connected,
             is_synced,
             admission_state,
+            node_counts,
             nodes,
         )
         self._compute_hosts[compute_id] = new_compute_host
@@ -380,6 +384,7 @@ def __init__(
         is_connected: bool,
         is_synced: bool,
         admission_state: str,
+        node_counts: dict[str, int],
         nodes: list[str] | None = None,
     ):
         """
@@ -394,7 +399,9 @@ def __init__(
         :param is_connected: Whether the compute host is connected.
         :param is_synced: Whether the compute host is synced.
         :param admission_state: The admission state of the compute host.
-        :param nodes: The list of nodes associated with the compute host.
+        :param node_counts: The counts of deployed and running nodes and orphans.
+        :param nodes: DEPRECATED: replaced by node_counts.
+            The list of node IDs associated with the compute host.
         """
         self._system = system
         self._session: httpx.Client = system._session
@@ -406,6 +413,7 @@ def __init__(
         self._is_connected = is_connected
         self._is_synced = is_synced
         self._admission_state = admission_state
+        self._node_counts = node_counts
         self._nodes = nodes if nodes is not None else []
 
     def __str__(self):
@@ -461,9 +469,20 @@ def is_synced(self) -> bool:
         self._system.sync_compute_hosts_if_outdated()
         return self._is_synced
 
+    @property
+    def node_counts(self) -> dict[str, int]:
+        """Return the counts of deployed and running nodes and orphans."""
+        self._system.sync_compute_hosts_if_outdated()
+        return self._node_counts
+
     @property
     def nodes(self) -> list[str]:
         """Return the list of nodes associated with the compute host."""
+        warnings.warn(
+            "'ComputeHost.nodes' is deprecated. Use 'ComputeHost.node_counts' or "
+            "'ClientLibrary.get_diagnostics(DiagnosticsCategory.COMPUTES)' instead.",
+            DeprecationWarning,
+        )
         self._system.sync_compute_hosts_if_outdated()
         return self._nodes