Skip to content

Commit 5c7a53e

Browse files
sajaganalhercot
authored andcommitted
[ignore] Changed the module attribute name destination_port.path to destination_port.interface and updated documentation
1 parent 95d1f6b commit 5c7a53e

File tree

2 files changed

+14
-13
lines changed

2 files changed

+14
-13
lines changed

plugins/modules/ndo_fabric_span_session.py

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,8 @@
118118
type: str
119119
source_ip_prefix:
120120
description:
121-
- The destination IP address prefix to route SPAN Session packets.
121+
- The prefix used to assign source IP addresses to ERSPAN packets which can be used to identify which Leaf or Spine is sending the traffic.
122+
- This can be any IP. If the prefix is used, the node ID of the source node is used for the undefined bits of the prefix.
122123
type: str
123124
span_version:
124125
description:
@@ -191,12 +192,12 @@
191192
suboptions:
192193
node:
193194
description:
194-
- The Node ID to use for the SPAN Session.
195+
- The Node ID of the Node to use for the SPAN Session.
195196
type: int
196197
required: true
197-
path:
198+
interface:
198199
description:
199-
- The Node Ethernet interface to use for the SPAN Session.
200+
- The Ethernet interface of the Node to use for the SPAN Session
200201
type: str
201202
required: true
202203
destination_port_channel:
@@ -282,7 +283,7 @@
282283
destination_port:
283284
port:
284285
node: 101
285-
path: "eth1/1"
286+
interface: "eth1/1"
286287
state: present
287288
288289
- name: Create Fabric SPAN Session with destination Port Channel
@@ -308,7 +309,7 @@
308309
destination_port:
309310
port:
310311
node: 101
311-
path: "eth1/1"
312+
interface: "eth1/1"
312313
state: present
313314
314315
- name: Update Fabric SPAN Session from destination Port to destination Port Channel
@@ -456,7 +457,7 @@ def main():
456457
type="dict",
457458
options=dict(
458459
node=dict(type="int", required=True),
459-
path=dict(type="str", required=True),
460+
interface=dict(type="str", required=True),
460461
),
461462
),
462463
),
@@ -571,7 +572,7 @@ def main():
571572

572573
if destination_port_uuid is None:
573574
node = destination_port.get("port").get("node")
574-
interface_port = destination_port.get("port").get("path")
575+
interface_port = destination_port.get("port").get("interface")
575576
destination_port_uuid = mso.get_site_interface_details(site_id=site_id, uuid=None, node=node, port=interface_port).get("uuid")
576577
mso_values["destination"] = dict(local=dict(accessInterface=destination_port_uuid), mtu=mtu)
577578

tests/integration/targets/ndo_fabric_span_session/tasks/main.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -240,7 +240,7 @@
240240
destination_port:
241241
port:
242242
node: 101
243-
path: "eth1/1"
243+
interface: "eth1/1"
244244
state: present
245245
register: add_port_span_session
246246

@@ -453,7 +453,7 @@
453453
destination_port:
454454
port:
455455
node: 101
456-
path: "eth1/2"
456+
interface: "eth1/2"
457457
admin_state: enabled
458458
mtu: 1520
459459
state: present
@@ -478,7 +478,7 @@
478478
destination_port:
479479
port:
480480
node: 101
481-
path: "eth1/1"
481+
interface: "eth1/1"
482482
state: present
483483
register: epg_to_port_span_session
484484

@@ -521,7 +521,7 @@
521521
destination_port:
522522
port:
523523
node: 101
524-
path: "eth1/1"
524+
interface: "eth1/1"
525525
state: present
526526
register: port_channel_to_port_span_session
527527

@@ -817,7 +817,7 @@
817817
destination_port:
818818
port:
819819
node: 1011
820-
path: eth1/1
820+
interface: "eth1/1"
821821
state: present
822822
register: nt_add_with_invalid_destination_port
823823
ignore_errors: true

0 commit comments

Comments
 (0)