fix: stop rollout from entering degraded state during blueGreen pause. Fixes argoproj#3843 (argoproj#3845)

miles-w-3 · meeech · commit b99b62485831 · 2025-02-10T16:44:17.000-05:00
add check for overall pause condition to indefinite step

Signed-off-by: Miles &lt;miles.wilson@wolterskluwer.com&gt;
Co-authored-by: Miles &lt;miles.wilson@wolterskluwer.com&gt;
diff --git a/rollout/sync.go b/rollout/sync.go
@@ -562,7 +562,10 @@ func isIndefiniteStep(r *v1alpha1.Rollout) bool {
 	if currentStep != nil && (currentStep.Experiment != nil || currentStep.Analysis != nil || currentStep.Pause != nil) {
 		return true
 	}
-	return false
+	// also check the pause condition to cover blueGreen
+	pauseCond := conditions.GetRolloutCondition(r.Status, v1alpha1.RolloutPaused)
+	pausedCondTrue := pauseCond != nil && pauseCond.Status == corev1.ConditionTrue
+	return pausedCondTrue
 }
 
 // isWaitingForReplicaSetScaleDown returns whether or not the rollout still has other replica sets with a scale down deadline annotation

Original file line number	Diff line number	Diff line change
`@@ -562,7 +562,10 @@ func isIndefiniteStep(r *v1alpha1.Rollout) bool {`
`562`	`562`	`if currentStep != nil && (currentStep.Experiment != nil \|\| currentStep.Analysis != nil \|\| currentStep.Pause != nil) {`
`563`	`563`	`return true`
`564`	`564`	`}`
`565`		`- return false`
	`565`	`+ // also check the pause condition to cover blueGreen`
	`566`	`+ pauseCond := conditions.GetRolloutCondition(r.Status, v1alpha1.RolloutPaused)`
	`567`	`+ pausedCondTrue := pauseCond != nil && pauseCond.Status == corev1.ConditionTrue`
	`568`	`+ return pausedCondTrue`
`566`	`569`	`}`
`567`	`570`
`568`	`571`	`// isWaitingForReplicaSetScaleDown returns whether or not the rollout still has other replica sets with a scale down deadline annotation`