Handle change in PHPUnit invocation syntax #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
agarzola
reviewed
Mar 25, 2025
There was a problem hiding this comment.
Code changes look great. I assume you will test this in a couple of our projects (each with a different version of PHPUnit) before cutting a new release, and that you can do so more efficiently and competently than I possibly could!
I am leaving some questions and suggestions, but the code changes here look great.
|
thank you for your comments and suggestions Alfonso. I have added the todo you requested and will mention the changes in the release notes. Just passing this back to you for anything else you might want to add and for approval. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This merge request allows for invoking
robo job:run-unit-testsacross PHPUnit version < 10 and > 10. PHPUnit 10 dropped support for the--verboseflag.Motivation / Context
Resolves #233
Resolves #234
Testing Instructions / How This Has Been Tested
Require this branch of Usher in your project and run
robo job:run-unit-tests. It would be especially good to test this in a project that uses PHPUnit 9 (or lower) and one that uses PHPUnit v 10 (or higher).