Skip to content

Unsubscribe from redis subscriptions asynchronously #8199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dannyheard7 opened this issue Mar 31, 2025 · 1 comment · Fixed by #8200
Closed

Unsubscribe from redis subscriptions asynchronously #8199

dannyheard7 opened this issue Mar 31, 2025 · 1 comment · Fixed by #8200
Labels
🌶️ hot chocolate
Milestone
HC-15.1.4

Comments

@dannyheard7
Copy link
Contributor

dannyheard7 commented Mar 31, 2025 •
edited
Loading

Product

Hot Chocolate

Is your feature request related to a problem?

Currently the RedisTopic unsubcribes synchronously. This means that if you have a number of subscribtions completing at the same time, the applicaton threads are locked which can result in thread pool starvation.

The solution you'd like

RedisTopic should unsubscribe asynchronously meaning the threads are freed up for other work.
@dannyheard7 dannyheard7 mentioned this issue Mar 31, 2025
Merged
@michaelstaib michaelstaib added this to the HC-15.1.4 milestone Mar 31, 2025
@dannyheard7
Copy link
Contributor Author

Would we want to consider changing the returned interface in DefaultTopic to IAsyncDisposable in 16? At the moment this is a hidden feature for implementers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🌶️ hot chocolate
Projects
None yet
Milestone
HC-15.1.4
Development

Successfully merging a pull request may close this issue.

Unsubscribe from redis topic async dannyheard7/graphql-platform
2 participants
@dannyheard7 @michaelstaib