Added switch to disable the DateTime format check. (#8289)

Author: michaelstaib

src/HotChocolate/Core/src/Types/Types/Scalars/DateTimeType.cs

@@ -24,17 +24,33 @@ public class DateTimeType : ScalarType<DateTimeOffset, StringValueNode>
         @"^[0-9]{4}-[0-9]{2}-[0-9]{2}T[0-9]{2}:[0-9]{2}:[0-9]{2}(\.[0-9]{1,7})?(Z|[+-][0-9]{2}:[0-9]{2})$",
         RegexOptions.IgnoreCase | RegexOptions.ExplicitCapture | RegexOptions.Compiled);
 
+    private readonly bool _enforceSpecFormat;
+
     /// <summary>
     /// Initializes a new instance of the <see cref="DateTimeType"/> class.
     /// </summary>
     public DateTimeType(
         string name,
         string? description = null,
-        BindingBehavior bind = BindingBehavior.Explicit)
+        BindingBehavior bind = BindingBehavior.Explicit,
+        bool disableFormatCheck = false)
         : base(name, bind)
     {
         Description = description;
         SpecifiedBy = new Uri(_specifiedBy);
+        _enforceSpecFormat = !disableFormatCheck;
+    }
+
+    /// <summary>
+    /// Initializes a new instance of the <see cref="DateTimeType"/> class.
+    /// </summary>
+    public DateTimeType(bool disableFormatCheck)
+        : this(
+            ScalarNames.DateTime,
+            TypeResources.DateTimeType_Description,
+            BindingBehavior.Implicit,
+            disableFormatCheck: disableFormatCheck)
+    {
     }
 
     /// <summary>
@@ -45,7 +61,8 @@ public DateTimeType()
         : this(
             ScalarNames.DateTime,
             TypeResources.DateTimeType_Description,
-            BindingBehavior.Implicit)
+            BindingBehavior.Implicit,
+            disableFormatCheck: false)
     {
     }
 
@@ -163,7 +180,7 @@ private static string Serialize(DateTimeOffset value)
             CultureInfo.InvariantCulture);
     }
 
-    private static bool TryDeserializeFromString(
+    private bool TryDeserializeFromString(
         string? serialized,
         [NotNullWhen(true)] out DateTimeOffset? value)
     {
@@ -174,7 +191,7 @@ private static bool TryDeserializeFromString(
         }
 
         // Check format.
-        if (!DateTimeScalarRegex.IsMatch(serialized))
+        if (_enforceSpecFormat && !DateTimeScalarRegex.IsMatch(serialized))
         {
             value = null;
             return false;

src/HotChocolate/Core/test/Types.Tests/Types/Scalars/DateTimeTypeTests.cs

@@ -85,8 +85,7 @@ public void ParseLiteral_StringValueNode()
             new TimeSpan(4, 0, 0));
 
         // act
-        var dateTime = (DateTimeOffset)dateTimeType
-            .ParseLiteral(literal);
+        var dateTime = (DateTimeOffset)dateTimeType.ParseLiteral(literal)!;
 
         // assert
         Assert.Equal(expectedDateTime, dateTime);
@@ -147,8 +146,7 @@ public void ParseLiteral_StringValueNode_DifferentCulture(string cultureName)
             new TimeSpan(4, 0, 0));
 
         // act
-        var dateTime = (DateTimeOffset)dateTimeType
-            .ParseLiteral(literal);
+        var dateTime = (DateTimeOffset)dateTimeType.ParseLiteral(literal)!;
 
         // assert
         Assert.Equal(expectedDateTime, dateTime);
@@ -164,8 +162,7 @@ public void Deserialize_IsoString_DateTimeOffset()
             new TimeSpan(4, 0, 0));
 
         // act
-        var deserializedValue = (DateTimeOffset)dateTimeType
-            .Deserialize("2018-06-11T08:46:14+04:00");
+        var deserializedValue = (DateTimeOffset)dateTimeType.Deserialize("2018-06-11T08:46:14+04:00")!;
 
         // assert
         Assert.Equal(dateTime, deserializedValue);
@@ -181,8 +178,7 @@ public void Deserialize_ZuluString_DateTimeOffset()
             new TimeSpan(0, 0, 0));
 
         // act
-        var deserializedValue = (DateTimeOffset)dateTimeType
-            .Deserialize("2018-06-11T08:46:14.000Z");
+        var deserializedValue = (DateTimeOffset)dateTimeType.Deserialize("2018-06-11T08:46:14.000Z")!;
 
         // assert
         Assert.Equal(dateTime, deserializedValue);
@@ -203,8 +199,7 @@ public void Deserialize_IsoString_DateTime()
             DateTimeKind.Unspecified);
 
         // act
-        var deserializedValue = ((DateTimeOffset)dateTimeType
-            .Deserialize("2018-06-11T08:46:14+04:00")).DateTime;
+        var deserializedValue = ((DateTimeOffset)dateTimeType.Deserialize("2018-06-11T08:46:14+04:00")!).DateTime;
 
         // assert
         Assert.Equal(dateTime, deserializedValue);
@@ -226,8 +221,7 @@ public void Deserialize_ZuluString_DateTime()
             DateTimeKind.Utc);
 
         // act
-        var deserializedValue = ((DateTimeOffset)dateTimeType
-            .Deserialize("2018-06-11T08:46:14.000Z"));
+        var deserializedValue = (DateTimeOffset)dateTimeType.Deserialize("2018-06-11T08:46:14.000Z")!;
 
         // assert
         Assert.Equal(dateTime, deserializedValue.UtcDateTime);
@@ -240,7 +234,7 @@ public void Deserialize_InvalidString_To_DateTimeOffset()
         var type = new DateTimeType();
 
         // act
-        var success = type.TryDeserialize("abc", out var deserialized);
+        var success = type.TryDeserialize("abc", out _);
 
         // assert
         Assert.False(success);
@@ -415,6 +409,20 @@ public async Task Integration_DefaultDateTime()
         res.ToJson().MatchSnapshot();
     }
 
+    [Fact]
+    public void DateTime_Relaxed_Format_Check()
+    {
+        // arrange
+        const string s = "2011-08-30";
+
+        // act
+        var dateTimeType = new DateTimeType(disableFormatCheck: true);
+        var result = dateTimeType.Deserialize(s);
+
+        // assert
+        Assert.IsType<DateTimeOffset>(result);
+    }
+
     public class DefaultDateTime
     {
         public DateTime Test => default;