Make it work with execution abstractions

Author: tobias-tengler

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/Completion/CompositeInputObjectTypeCompletionContext.cs

@@ -1,9 +1,13 @@
+using HotChocolate.Features;
 using HotChocolate.Fusion.Types.Collections;
 
 namespace HotChocolate.Fusion.Types.Completion;
 
 internal ref struct CompositeInputObjectTypeCompletionContext(
-    FusionDirectiveCollection directives)
+    FusionDirectiveCollection directives,
+    IFeatureCollection features)
 {
     public FusionDirectiveCollection Directives { get; } = directives;
+
+    public IFeatureCollection Features { get; } = features;
 }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/Completion/CompositeSchemaBuilder.cs

@@ -349,7 +349,7 @@ private static void CompleteUnionType(
     {
         var directives = CompletionTools.CreateDirectiveCollection(typeDef.Directives, schemaContext);
         var types = CompletionTools.CreateObjectTypeCollection(typeDef.Types, schemaContext);
-        type.Complete(new CompositeUnionTypeCompletionContext(directives, types));
+        type.Complete(new CompositeUnionTypeCompletionContext(types, directives, FeatureCollection.Empty));
     }
 
     private static void CompleteOutputField(
@@ -451,11 +451,11 @@ private static void CompleteInputObjectType(
     {
         foreach (var fieldDef in inputObjectTypeDef.Fields)
         {
-            CompleteInputField(inputObjectType.Fields[fieldDef.Name.Value], fieldDef, schemaContext);
+            CompleteInputField(inputObjectType, inputObjectType.Fields[fieldDef.Name.Value], fieldDef, schemaContext);
         }
 
         var directives = CompletionTools.CreateDirectiveCollection(inputObjectTypeDef.Directives, schemaContext);
-        inputObjectType.Complete(new CompositeInputObjectTypeCompletionContext(directives));
+        inputObjectType.Complete(new CompositeInputObjectTypeCompletionContext(directives, FeatureCollection.Empty));
     }
 
     private static void CompleteInputField(

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/Completion/CompositeUnionTypeCompletionContext.cs

@@ -1,12 +1,16 @@
+using HotChocolate.Features;
 using HotChocolate.Fusion.Types.Collections;
 
 namespace HotChocolate.Fusion.Types.Completion;
 
 internal ref struct CompositeUnionTypeCompletionContext(
+    FusionObjectTypeDefinitionCollection types,
     FusionDirectiveCollection directives,
-    FusionObjectTypeDefinitionCollection types)
+    IFeatureCollection features)
 {
     public FusionDirectiveCollection Directives { get; } = directives;
 
     public FusionObjectTypeDefinitionCollection Types { get; } = types;
+
+    public IFeatureCollection Features { get; } = features;
 }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/FusionInputObjectTypeDefinition.cs

@@ -1,43 +1,75 @@
+using HotChocolate.Features;
 using HotChocolate.Fusion.Types.Collections;
 using HotChocolate.Fusion.Types.Completion;
 using HotChocolate.Language;
 using HotChocolate.Serialization;
 using HotChocolate.Types;
+using static HotChocolate.Fusion.Types.ThrowHelper;
 
 namespace HotChocolate.Fusion.Types;
 
-public sealed class FusionInputObjectTypeDefinition(
-    string name,
-    string? description,
-    FusionInputFieldDefinitionCollection fields)
-    : IInputObjectTypeDefinition
+public sealed class FusionInputObjectTypeDefinition : IInputObjectTypeDefinition
 {
-    private FusionDirectiveCollection _directives = default!;
     private bool _completed;
 
+    public FusionInputObjectTypeDefinition(
+        string name,
+        string? description,
+        FusionInputFieldDefinitionCollection fields)
+    {
+        Name = name;
+        Description = description;
+        Fields = fields;
+
+        // these properties are initialized
+        // in the type complete step.
+        Directives = null!;
+        Features = null!;
+    }
+
     /// <inheritdoc />
     public TypeKind Kind => TypeKind.InputObject;
 
     /// <inheritdoc />
     public SchemaCoordinate Coordinate => new(Name, ofDirective: false);
 
-    public string Name => name;
-
-    public string? Description => description;
+    public string Name { get; }
 
-    public FusionDirectiveCollection Directives => _directives;
+    public string? Description { get; }
 
-    public FusionInputFieldDefinitionCollection Fields => fields;
+    public FusionInputFieldDefinitionCollection Fields { get; }
 
     IReadOnlyFieldDefinitionCollection<IInputValueDefinition> IInputObjectTypeDefinition.Fields => Fields;
 
-    IReadOnlyDirectiveCollection IDirectivesProvider.Directives => Directives;
+    public FusionDirectiveCollection Directives
+    {
+        get;
+        private set
+        {
+            EnsureNotSealed(_completed);
+            field = value;
+        }
+    }
+
+    IReadOnlyDirectiveCollection IDirectivesProvider.Directives
+        => Directives;
+
+    public IFeatureCollection Features
+    {
+        get;
+        private set
+        {
+            EnsureNotSealed(_completed);
+            field = value;
+        }
+    }
 
     internal void Complete(CompositeInputObjectTypeCompletionContext context)
     {
-        ThrowHelper.EnsureNotSealed(_completed);
+        EnsureNotSealed(_completed);
 
-        _directives = context.Directives;
+        Directives = context.Directives;
+        Features = context.Features;
 
         _completed = true;
     }

src/HotChocolate/Fusion-vnext/src/Fusion.Execution.Types/FusionUnionTypeDefinition.cs

@@ -4,42 +4,78 @@
 using HotChocolate.Language;
 using HotChocolate.Serialization;
 using HotChocolate.Types;
+using static HotChocolate.Fusion.Types.ThrowHelper;
 
 namespace HotChocolate.Fusion.Types;
 
-public sealed class FusionUnionTypeDefinition(
-    string name,
-    string? description)
-    : IUnionTypeDefinition
+public sealed class FusionUnionTypeDefinition : IUnionTypeDefinition
 {
-    private FusionObjectTypeDefinitionCollection _types = default!;
-    private FusionDirectiveCollection _directives = default!;
     private bool _completed;
 
-    public string Name { get; } = name;
+    public FusionUnionTypeDefinition(string name, string? description)
+    {
+        Name = name;
+        Description = description;
+
+        // these properties are initialized
+        // in the type complete step.
+        Types = null!;
+        Directives = null!;
+        Features = null!;
+    }
 
-    public string? Description { get; } = description;
+    public string Name { get; }
 
-    public FusionDirectiveCollection Directives => _directives;
+    public string? Description { get; }
 
     public TypeKind Kind => TypeKind.Union;
 
     public SchemaCoordinate Coordinate => new(Name, ofDirective: false);
 
-    public FusionObjectTypeDefinitionCollection Types => _types;
+    public FusionObjectTypeDefinitionCollection Types
+    {
+        get;
+        private set
+        {
+            EnsureNotSealed(_completed);
+            field = value;
+        }
+    }
+
+    IReadOnlyObjectTypeDefinitionCollection IUnionTypeDefinition.Types => Types;
+
+    public FusionDirectiveCollection Directives
+    {
+        get;
+        private set
+        {
+            EnsureNotSealed(_completed);
+            field = value;
+        }
+    }
 
-    IReadOnlyObjectTypeDefinitionCollection IUnionTypeDefinition.Types => _types;
+    IReadOnlyDirectiveCollection IDirectivesProvider.Directives
+        => Directives;
 
-    IReadOnlyDirectiveCollection IDirectivesProvider.Directives => Directives;
 
-    public IFeatureCollection Features => throw new NotImplementedException();
+    public IFeatureCollection Features
+    {
+        get;
+        private set
+        {
+            EnsureNotSealed(_completed);
+            field = value;
+        }
+    }
 
     internal void Complete(CompositeUnionTypeCompletionContext context)
     {
-        ThrowHelper.EnsureNotSealed(_completed);
+        EnsureNotSealed(_completed);
+
+        Directives = context.Directives;
+        Types = context.Types;
+        Features = context.Features;
 
-        _directives = context.Directives;
-        _types = context.Types;
         _completed = true;
     }
 
@@ -55,8 +91,7 @@ public bool Equals(IType? other, TypeComparison comparison)
             return ReferenceEquals(this, other);
         }
 
-        return other is FusionUnionTypeDefinition otherUnion
-            && otherUnion.Name.Equals(Name, StringComparison.Ordinal);
+        return other is FusionUnionTypeDefinition otherUnion && otherUnion.Name.Equals(Name, StringComparison.Ordinal);
     }
 
     public bool IsAssignableFrom(ITypeDefinition type)
@@ -67,14 +102,14 @@ public bool IsAssignableFrom(ITypeDefinition type)
                 return ReferenceEquals(type, this);
 
             case TypeKind.Object:
-                return _types.ContainsName(((FusionObjectTypeDefinition)type).Name);
+                return Types.ContainsName(((FusionObjectTypeDefinition)type).Name);
 
             default:
                 return false;
         }
     }
 
-     /// <summary>
+    /// <summary>
     /// Get the string representation of the union type definition.
     /// </summary>
     /// <returns>