Skip to content

bug(cloudformation): false positive for: ECS Cluster should enable container insights #7338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
slyfer opened this issue Feb 17, 2025 · 0 comments
Labels
aws PR related with AWS Cloud bug Something isn't working cloudformation CloudFormation query community Community contribution

Comments

@slyfer
Copy link

slyfer commented Feb 17, 2025

Expected Behavior

KICS recognise "enhanced" as "enabled"

Actual Behavior

Kics report an info

{
            "id": "be8f2aeb2e221eaa9dbbb2fd4c608a1a6d4df6bec5fc8112c8aff05d73c92ce5",
            "category": "sast",
            "name": "ECS Cluster with Container Insights Disabled",
            "description": "ECS Cluster should enable container insights",
            "cve": "kics_id:ab759fde-e1e8-4b0e-ad73-ba856e490ed8:26:0",
            "severity": "Info",
            "scanner": {
                "id": "kics",
                "name": "kics"
            },
            "location": {
                "file": "src/infra.yaml",
                "start_line": 26
            },
            "identifiers": [
                {
                    "type": "kics_id",
                    "name": "ECS Cluster with Container Insights Disabled",
                    "value": "ab759fde-e1e8-4b0e-ad73-ba856e490ed8",
                    "url": "https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ecs-cluster.html#cfn-ecs-cluster-clustersettings"
                }
            ]
        }

Steps to Reproduce the Problem

Example of cloudformation yaml

AWSTemplateFormatVersion: "2010-09-09"

Resources:

  # ECS Resources
  ECSCluster:
    Type: AWS::ECS::Cluster
    Properties:
      ClusterName: mycluster
      ClusterSettings:
        - Name: containerInsights
          Value: enhanced
      Configuration:
        ExecuteCommandConfiguration:
          Logging: DEFAULT
      ServiceConnectDefaults:
        Namespace: ecs

Specifications

  • Version: v2.1.3
  • Platform: Gitlab
@slyfer slyfer added bug Something isn't working community Community contribution labels Feb 17, 2025
@github-actions github-actions bot added cloudformation CloudFormation query aws PR related with AWS Cloud labels Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws PR related with AWS Cloud bug Something isn't working cloudformation CloudFormation query community Community contribution
Projects
None yet
Development

No branches or pull requests

1 participant