Skip to content

Sending on a closed channel in networks package #2567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kishansagathiya opened this issue May 25, 2022 · 1 comment
Closed

Sending on a closed channel in networks package #2567

kishansagathiya opened this issue May 25, 2022 · 1 comment
Assignees

Comments

@kishansagathiya
Copy link
Contributor

Describe the bug

  • found this on one of the ci unit tests logs panic: send on closed channel
  • Relevant logs might be this
2022-05-25T13:43:24.3252053Z 2022-05-25T13:43:24Z INFO started network service with supported protocols /p2p/id/delta/1.0.0, /ipfs/id/1.0.0, /ipfs/id/push/1.0.0, /ipfs/ping/1.0.0, /gossamer/test/0/sync/2, /gossamer/test/0/light/2, /gossamer/test/0/block-announces/1, /gossamer/test/0/transactions/1	pkg=network
2022-05-25T13:43:24.3252553Z panic: send on closed channel
2022-05-25T13:43:24.3252708Z 
2022-05-25T13:43:24.3252815Z goroutine 10060 [running]:
2022-05-25T13:43:24.3253197Z github.com/ChainSafe/gossamer/dot/peerset.(*PeerSet).disconnect(0xc04b8d8200, 0x0, 0x0, {0xc04d65fe00, 0x1, 0x1?})
2022-05-25T13:43:24.3253660Z 	/home/runner/work/gossamer/gossamer/dot/peerset/peerset.go:693 +0x26f
2022-05-25T13:43:24.3254166Z github.com/ChainSafe/gossamer/dot/peerset.(*PeerSet).listenAction(0xc04b8d8200, {0x13b6200, 0xc04d62c380})
2022-05-25T13:43:24.3254611Z 	/home/runner/work/gossamer/gossamer/dot/peerset/peerset.go:752 +0x1b4
2022-05-25T13:43:24.3254996Z created by github.com/ChainSafe/gossamer/dot/peerset.(*PeerSet).start
2022-05-25T13:43:24.3255402Z 	/home/runner/work/gossamer/gossamer/dot/peerset/peerset.go:715 +0xea
2022-05-25T13:43:24.3255751Z FAIL	github.com/ChainSafe/gossamer/dot/network	77.287s

Expected Behavior

  • We should not be sending things on closed channels

Current Behavior

Possible Solution

To Reproduce

  • Running./dot/network unit tests should do it.

Log output

Specification

  • go version:
  • gossamer version:
  • gossamer commit tag:
  • gossamer commit hash:
  • operating system:
  • additional links:
@kishansagathiya
Copy link
Contributor Author

closed in #2573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants