feat(dot/network): add mismatched genesis peer reporting (#2265)

* add mismatch genesis peer reporting

* double timeout in compareBlocksByNumberWithRetry

* add more timeout

* try to fix checks

Author: timwu20

.github/workflows/checks.yml

@@ -1,9 +1,5 @@
 on:
   pull_request:
-    types:
-      - opened
-      - edited
-      - reopened
     paths:
       - .github/workflows/checks.yml
       - .github/PULL_REQUEST/pull_request.go

dot/network/block_announce.go

@@ -8,6 +8,7 @@ import (
 	"fmt"
 	"math/big"
 
+	"github.com/ChainSafe/gossamer/dot/peerset"
 	"github.com/ChainSafe/gossamer/dot/types"
 	"github.com/ChainSafe/gossamer/lib/common"
 	"github.com/ChainSafe/gossamer/pkg/scale"
@@ -176,6 +177,10 @@ func (s *Service) validateBlockAnnounceHandshake(from peer.ID, hs Handshake) err
 	}
 
 	if bhs.GenesisHash != s.blockState.GenesisHash() {
+		s.host.cm.peerSetHandler.ReportPeer(peerset.ReputationChange{
+			Value:  peerset.GenesisMismatch,
+			Reason: peerset.GenesisMismatchReason,
+		}, from)
 		return errors.New("genesis hash mismatch")
 	}
 

dot/peerset/constants.go

@@ -62,4 +62,9 @@ const (
 	BadJustificationValue Reputation = -(1 << 16)
 	// BadJustificationReason is used when peer send invalid justification.
 	BadJustificationReason = "Bad justification"
+
+	// GenesisMismatch is used when peer has a different genesis
+	GenesisMismatch Reputation = math.MinInt32
+	// GenesisMismatchReason used when a peer has a different genesis
+	GenesisMismatchReason = "Genesis mismatch"
 )

tests/stress/helpers.go

@@ -113,7 +113,7 @@ func compareBlocksByNumberWithRetry(t *testing.T, nodes []*utils.Node, num strin
 	var hashes map[common.Hash][]string
 	var err error
 
-	timeout := time.After(30 * time.Second)
+	timeout := time.After(60 * time.Second)
 doneBlockProduction:
 	for {
 		time.Sleep(time.Second)

tests/stress/stress_test.go

@@ -102,7 +102,7 @@ func TestSync_SingleBlockProducer(t *testing.T) {
 	require.NoError(t, err)
 	nodes = append(nodes, node)
 
-	time.Sleep(time.Second * 30)
+	time.Sleep(time.Second * 60)
 
 	defer func() {
 		errList := utils.StopNodes(t, nodes)